Skip to content

Commit 9709a34

Browse files
committed
rm some defaults from base
1 parent 5fe3669 commit 9709a34

File tree

1 file changed

+18
-16
lines changed

1 file changed

+18
-16
lines changed

src/apify_client/_resource_clients/_resource_client.py

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ def __init__(
193193
params=params,
194194
)
195195

196-
def _get(self, *, timeout: Timeout = 'long') -> dict | None:
196+
def _get(self, *, timeout: Timeout) -> dict | None:
197197
"""Perform a GET request for this resource, returning the parsed response or None if not found."""
198198
try:
199199
response = self._http_client.call(
@@ -207,7 +207,7 @@ def _get(self, *, timeout: Timeout = 'long') -> dict | None:
207207
catch_not_found_or_throw(exc)
208208
return None
209209

210-
def _update(self, *, timeout: Timeout = 'long', **kwargs: Any) -> dict:
210+
def _update(self, *, timeout: Timeout, **kwargs: Any) -> dict:
211211
"""Perform a PUT request to update this resource with the given fields."""
212212
response = self._http_client.call(
213213
url=self._build_url(),
@@ -218,7 +218,7 @@ def _update(self, *, timeout: Timeout = 'long', **kwargs: Any) -> dict:
218218
)
219219
return response_to_dict(response)
220220

221-
def _delete(self, *, timeout: Timeout = 'long') -> None:
221+
def _delete(self, *, timeout: Timeout) -> None:
222222
"""Perform a DELETE request to delete this resource, ignoring 404 errors."""
223223
try:
224224
self._http_client.call(
@@ -230,7 +230,7 @@ def _delete(self, *, timeout: Timeout = 'long') -> None:
230230
except ApifyApiError as exc:
231231
catch_not_found_or_throw(exc)
232232

233-
def _list(self, *, timeout: Timeout = 'long', **kwargs: Any) -> dict:
233+
def _list(self, *, timeout: Timeout, **kwargs: Any) -> dict:
234234
"""Perform a GET request to list resources."""
235235
response = self._http_client.call(
236236
url=self._build_url(),
@@ -240,7 +240,7 @@ def _list(self, *, timeout: Timeout = 'long', **kwargs: Any) -> dict:
240240
)
241241
return response_to_dict(response)
242242

243-
def _create(self, *, timeout: Timeout = 'long', **kwargs: Any) -> dict:
243+
def _create(self, *, timeout: Timeout, **kwargs: Any) -> dict:
244244
"""Perform a POST request to create a resource."""
245245
response = self._http_client.call(
246246
url=self._build_url(),
@@ -256,7 +256,7 @@ def _get_or_create(
256256
*,
257257
name: str | None = None,
258258
resource_fields: dict | None = None,
259-
timeout: Timeout = 'long',
259+
timeout: Timeout,
260260
) -> dict:
261261
"""Perform a POST request to get or create a named resource."""
262262
response = self._http_client.call(
@@ -270,10 +270,11 @@ def _get_or_create(
270270

271271
def _wait_for_finish(
272272
self,
273+
*,
273274
url: str,
274275
params: dict,
276+
timeout: Timeout,
275277
wait_duration: timedelta | None = None,
276-
timeout: Timeout = 'no_timeout',
277278
) -> dict | None:
278279
"""Wait synchronously for an Actor job (run or build) to finish.
279280
@@ -283,8 +284,8 @@ def _wait_for_finish(
283284
Args:
284285
url: Full URL to the job endpoint.
285286
params: Base query parameters to include in each request.
286-
wait_duration: Maximum time to wait (None = indefinite).
287287
timeout: Timeout for each individual HTTP request.
288+
wait_duration: Maximum time to wait (None = indefinite).
288289
289290
Returns:
290291
Job data dict when finished, or None if job doesn't exist after
@@ -372,7 +373,7 @@ def __init__(
372373
params=params,
373374
)
374375

375-
async def _get(self, *, timeout: Timeout = 'long') -> dict | None:
376+
async def _get(self, *, timeout: Timeout) -> dict | None:
376377
"""Perform a GET request for this resource, returning the parsed response or None if not found."""
377378
try:
378379
response = await self._http_client.call(
@@ -386,7 +387,7 @@ async def _get(self, *, timeout: Timeout = 'long') -> dict | None:
386387
catch_not_found_or_throw(exc)
387388
return None
388389

389-
async def _update(self, *, timeout: Timeout = 'long', **kwargs: Any) -> dict:
390+
async def _update(self, *, timeout: Timeout, **kwargs: Any) -> dict:
390391
"""Perform a PUT request to update this resource with the given fields."""
391392
response = await self._http_client.call(
392393
url=self._build_url(),
@@ -397,7 +398,7 @@ async def _update(self, *, timeout: Timeout = 'long', **kwargs: Any) -> dict:
397398
)
398399
return response_to_dict(response)
399400

400-
async def _delete(self, *, timeout: Timeout = 'long') -> None:
401+
async def _delete(self, *, timeout: Timeout) -> None:
401402
"""Perform a DELETE request to delete this resource, ignoring 404 errors."""
402403
try:
403404
await self._http_client.call(
@@ -409,7 +410,7 @@ async def _delete(self, *, timeout: Timeout = 'long') -> None:
409410
except ApifyApiError as exc:
410411
catch_not_found_or_throw(exc)
411412

412-
async def _list(self, *, timeout: Timeout = 'long', **kwargs: Any) -> dict:
413+
async def _list(self, *, timeout: Timeout, **kwargs: Any) -> dict:
413414
"""Perform a GET request to list resources."""
414415
response = await self._http_client.call(
415416
url=self._build_url(),
@@ -419,7 +420,7 @@ async def _list(self, *, timeout: Timeout = 'long', **kwargs: Any) -> dict:
419420
)
420421
return response_to_dict(response)
421422

422-
async def _create(self, *, timeout: Timeout = 'long', **kwargs: Any) -> dict:
423+
async def _create(self, *, timeout: Timeout, **kwargs: Any) -> dict:
423424
"""Perform a POST request to create a resource."""
424425
response = await self._http_client.call(
425426
url=self._build_url(),
@@ -435,7 +436,7 @@ async def _get_or_create(
435436
*,
436437
name: str | None = None,
437438
resource_fields: dict | None = None,
438-
timeout: Timeout = 'long',
439+
timeout: Timeout,
439440
) -> dict:
440441
"""Perform a POST request to get or create a named resource."""
441442
response = await self._http_client.call(
@@ -449,10 +450,11 @@ async def _get_or_create(
449450

450451
async def _wait_for_finish(
451452
self,
453+
*,
452454
url: str,
453455
params: dict,
456+
timeout: Timeout,
454457
wait_duration: timedelta | None = None,
455-
timeout: Timeout = 'no_timeout',
456458
) -> dict | None:
457459
"""Wait asynchronously for an Actor job (run or build) to finish.
458460
@@ -462,8 +464,8 @@ async def _wait_for_finish(
462464
Args:
463465
url: Full URL to the job endpoint.
464466
params: Base query parameters to include in each request.
465-
wait_duration: Maximum time to wait (None = indefinite).
466467
timeout: Timeout for each individual HTTP request.
468+
wait_duration: Maximum time to wait (None = indefinite).
467469
468470
Returns:
469471
Job data dict when finished, or None if job doesn't exist after

0 commit comments

Comments
 (0)