You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ci: use a TODO placeholder title for model-regeneration PRs (#901)
The auto-opened model-regeneration PR used to default its title to
`[TODO]: update generated models from apify-docs PR #N`. That looked
finished enough to merge as-is and tied the title to apify-docs, even
though the right title depends on the actual model diff (a routine
`chore:` sync, or a `refactor:`/`feat:`/`fix:` when models meaningfully
change).
The PR title is now a bare `TODO` placeholder. It carries no valid
Conventional Commits type, so `pr-title-check` stays red until a human
replaces it. The apify-docs reference and link, plus a `> [!IMPORTANT]`
note asking the assignee to replace both the title and the description,
now live in the PR body. The automated regeneration commit keeps its own
descriptive `chore:` message (separate from the PR title).
# The PR opens with a `TODO` placeholder title that fails `pr-title-check`. Spell out the required
191
+
# action: the assignee must replace both the PR title and this description before merging.
192
+
ACTION_NOTE=$'> [!IMPORTANT]\n> **Replace this PR title and description before merging.**\n> - Title: a Conventional Commits message describing the actual model changes (e.g. `chore: ...` for a routine sync, or `refactor:`/`feat:`/`fix:` when models meaningfully change).\n> - Description: summarize what changed in the models.\n\n'
BODY="This PR updates the auto-generated Pydantic models and TypedDicts based on OpenAPI specification changes in [apify-docs PR #${DOCS_PR_NUMBER}](${DOCS_PR_URL})."
195
+
BODY="${ACTION_NOTE}- Updates the auto-generated Pydantic models and TypedDicts based on the proposed OpenAPI specification changes."$'\n'"- Based on apify-docs PR [#${DOCS_PR_NUMBER}](${DOCS_PR_URL})."
187
196
else
188
-
BODY="This PR updates the auto-generated Pydantic models and TypedDicts from the [published OpenAPI specification](https://docs.apify.com/api/openapi.json)."
197
+
BODY="${ACTION_NOTE}- Updates the auto-generated Pydantic models and TypedDicts based on the latest OpenAPI specification changes."$'\n'"- Based on the [published OpenAPI specification](https://docs.apify.com/api/openapi.json)."
Copy file name to clipboardExpand all lines: .rules.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -82,7 +82,7 @@ Each input-side TypedDict ships in two casings: snake_case (`RequestDict`) and c
82
82
- To regenerate locally:
83
83
- From the live published spec: `uv run poe generate-models`
84
84
- From a local spec file: `uv run poe generate-models-from-file path/to/openapi.json`
85
-
- In CI, model regeneration is triggered automatically by the `apify/apify-docs` repo when its OpenAPI spec changes (workflow `manual_regenerate_models.yaml`). It downloads the pre-built `openapi-bundles` artifact from the apify-docs workflow run, opens a PR titled `[TODO]: update generated models from apify-docs PR #N`, assigns it to the docs PR author, and posts a cross-repo comment on the original apify-docs PR
85
+
- In CI, model regeneration is triggered automatically by the `apify/apify-docs` repo when its OpenAPI spec changes (workflow `manual_regenerate_models.yaml`). It downloads the pre-built `openapi-bundles` artifact from the apify-docs workflow run, opens a PR with a placeholder title (`TODO: replace with a Conventional Commits title...`) that the assignee must replace based on the actual model diff, assigns it to the docs PR author, and posts a cross-repo comment on the original apify-docs PR. The apify-docs PR reference lives in the PR body, not the title
86
86
- Manual regeneration is also possible from the GitHub Actions UI (`Regenerate models` workflow)
0 commit comments