Skip to content

Commit 1020ed2

Browse files
mnmkngTC-MO
andauthored
Apply suggestions from code review
Thanks for the fixes! Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
1 parent 11df06f commit 1020ed2

1 file changed

Lines changed: 18 additions & 18 deletions

File tree

  • sources/platform/actors/development/actor_definition

sources/platform/actors/development/actor_definition/docker.md

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,10 @@ Docker image tags follow a consistent naming pattern that allows you to pin spec
5757

5858
For Node.js images, the tag format is:
5959

60-
- `{node-version}` - Node.js version only (e.g., `20`, `22`, `24`)
61-
- `{node-version}-{library-version}` - Node.js version with pinned Playwright/Puppeteer version (e.g., `22-1.52.0`)
60+
- `{node-version}` - A Node.js version only (e.g., `20`, `22`, `24`)
61+
- `{node-version}-{library-version}` - A Node.js version with pinned Playwright/Puppeteer version (e.g., `22-1.52.0`)
6262

63-
**Examples:**
63+
Examples:
6464

6565
| Tag | Description |
6666
| --- | ----------- |
@@ -73,17 +73,17 @@ For Node.js images, the tag format is:
7373

7474
For Python images, the tag format is:
7575

76-
- `{python-version}` - Python version only (e.g., `3.11`, `3.12`, `3.13`)
77-
- `{python-version}-{library-version}` - Python version with pinned Playwright/Selenium version
76+
- `{python-version}` - A Python version only (e.g., `3.11`, `3.12`, `3.13`)
77+
- `{python-version}-{library-version}` - A Python version with pinned Playwright/Selenium version
7878

79-
### Finding available tags
79+
### Available tags
8080

81-
To see all available tags for an image, visit the Docker Hub tags page:
81+
To see all available tags for an image, visit Docker Hub:
8282

83-
- [actor-node-playwright-chrome tags](https://hub.docker.com/r/apify/actor-node-playwright-chrome/tags)
84-
- [actor-node-playwright tags](https://hub.docker.com/r/apify/actor-node-playwright/tags)
85-
- [actor-node-puppeteer-chrome tags](https://hub.docker.com/r/apify/actor-node-puppeteer-chrome/tags)
86-
- [actor-python-playwright tags](https://hub.docker.com/r/apify/actor-python-playwright/tags)
83+
- [View actor-node-playwright-chrome tags](https://hub.docker.com/r/apify/actor-node-playwright-chrome/tags)
84+
- [View actor-node-playwright tags](https://hub.docker.com/r/apify/actor-node-playwright/tags)
85+
- [View actor-node-puppeteer-chrome tags](https://hub.docker.com/r/apify/actor-node-puppeteer-chrome/tags)
86+
- [View actor-python-playwright tags](https://hub.docker.com/r/apify/actor-python-playwright/tags)
8787

8888
You can also query available tags programmatically:
8989

@@ -93,18 +93,18 @@ curl -s "https://registry.hub.docker.com/v2/repositories/apify/actor-node-playwr
9393

9494
## Version pinning for reproducible builds
9595

96-
For production Actors, we recommend pinning both the Node.js/Python version and the browser automation library version in your Dockerfile. This ensures reproducible builds and prevents unexpected behavior when new versions are released.
96+
For production Actors, pin both the Node.js/Python version and the browser automation library version in your Dockerfile. This ensures reproducible builds and prevents unexpected behavior when new versions are released.
9797

9898
### Recommended approach
9999

100-
**In your Dockerfile**, use a fully pinned tag:
100+
In your `Dockerfile`, use a fully pinned tag:
101101

102102
```dockerfile
103103
# Pin both Node.js 22 and Playwright 1.52.0
104104
FROM apify/actor-node-playwright-chrome:22-1.52.0
105105
```
106106

107-
**In your `package.json`**, match the Playwright/Puppeteer version to your Docker image tag:
107+
In your `package.json`, match the Playwright/Puppeteer version to your Docker image tag:
108108

109109
```json
110110
{
@@ -126,7 +126,7 @@ When the Playwright/Puppeteer version in your `package.json` differs from what's
126126

127127
:::
128128

129-
### Using `*` as version (legacy approach)
129+
### Using `*` as version (alternative approach)
130130

131131
You may encounter older documentation or templates using `*` as the Playwright/Puppeteer version:
132132

@@ -140,9 +140,9 @@ You may encounter older documentation or templates using `*` as the Playwright/P
140140

141141
The asterisk (`*`) tells npm to use whatever version is already installed, which prevents re-downloading the library. While this approach still works, **pinning specific versions is now preferred** because:
142142

143-
1. **Reproducibility** - Your builds will behave the same way regardless of when you build them
144-
2. **Predictability** - You know exactly which version you're running
145-
3. **Debugging** - Easier to track down version-specific issues
143+
1. Reproducibility - Your builds will behave the same way regardless of when you build them
144+
1. Predictability - You know exactly which version you're running
145+
1. Debugging - Version-specific issues are easier to track down
146146

147147
## Custom Dockerfile
148148

0 commit comments

Comments
 (0)