Commit e5b763a
authored
chore: few more improvements for the academy exercises (#2268)
- removes leftover file spotted by @TC-MO
- removes workaround as
apify/crawlee-python#1673 has been fixed
meanwhile by the Crawlee team
- adds tests which verify that each exercise has its test :)
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> Test-only changes plus deletion of an unused exercise script; minimal
production impact, with only a small risk of CI failures if tests are
missing or external scraping outputs change.
>
> **Overview**
> Improves the academy webscraping exercise test suites by adding a new
"covers all exercise scripts" check in both JS (`*.mjs`) and Python
(`*.py`) that fails when any exercise file lacks a corresponding test
invocation.
>
> Removes the leftover `wikipedia_calling_codes.mjs` exercise file, and
updates the Python Crawlee Netflix ratings test to assert an exact
dataset size (`-eq 5`) instead of the prior workaround.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
f68b908. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent 9a35701 commit e5b763a
3 files changed
Lines changed: 28 additions & 38 deletions
File tree
- sources/academy/webscraping
- scraping_basics_javascript/exercises
- scraping_basics_python/exercises
Lines changed: 13 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
15 | 28 | | |
16 | 29 | | |
17 | 30 | | |
| |||
Lines changed: 0 additions & 37 deletions
This file was deleted.
Lines changed: 15 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
9 | 23 | | |
10 | 24 | | |
11 | 25 | | |
| |||
141 | 155 | | |
142 | 156 | | |
143 | 157 | | |
144 | | - | |
| 158 | + | |
145 | 159 | | |
146 | 160 | | |
147 | 161 | | |
0 commit comments