-
Notifications
You must be signed in to change notification settings - Fork 191
docs(openapi): Autofix OpenAPI spec validation errors #2403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 11 commits
ecbb1b1
1d46f4b
dbf3175
2cc6a7d
84e88e9
0b907d7
d779733
cb46377
63945b4
c312f9d
775e660
56d8aa3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,6 +14,7 @@ shared: &shared | |
| - gzip | ||
| - deflate | ||
| - br | ||
| - identity | ||
| type: string | ||
| requestBody: | ||
| description: "" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,4 +6,5 @@ allOf: | |
| - pricingModel | ||
| properties: | ||
| pricingModel: | ||
| $ref: ./PricingModel.yaml | ||
| type: string | ||
| const: FREE | ||
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,6 @@ | ||
| title: CreateTaskRequest | ||
| required: | ||
| - actId | ||
| - name | ||
| type: object | ||
| properties: | ||
| actId: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,6 @@ | ||
| title: SourceCodeFile | ||
| type: object | ||
| required: | ||
| - format | ||
| - content | ||
| - name | ||
| properties: | ||
| format: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,7 +15,6 @@ UniqueKey: | |
|
|
||
| RequestUrl: | ||
| type: string | ||
| format: uri | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why are we removing these format constraints?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This constraint does not exist in API:
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably because you might also want to save PseudoURLs to the queue, not just regular URLs. It's been like this since the original implementation: https://github.com/apify/apify-core/commit/9bb347bd4baf62a23bda7c180ce58dd68cf30252#diff-48532f504598f9f0dc62bb5d060e1b3951b95c959d76e797f24e1e6bb155ddebR117
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oh hot damn... so will the API really accept any string?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There are still other fields using the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I will check that and align it in a separate PR.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| description: The URL of the request. | ||
| examples: [https://apify.com] | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -115,6 +115,8 @@ post: | |
| type: object | ||
| example: | ||
| foo: bar | ||
| "*/*": | ||
| schema: {} | ||
| required: true | ||
| responses: | ||
| "201": | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -106,6 +106,8 @@ post: | |
| type: object | ||
| example: | ||
| foo: bar | ||
| "*/*": | ||
| schema: {} | ||
| required: true | ||
| responses: | ||
| "201": | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,6 +42,8 @@ post: | |
| type: object | ||
| example: | ||
| foo: bar | ||
| "*/*": | ||
| schema: {} | ||
| required: true | ||
| responses: | ||
| "201": | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -117,6 +117,8 @@ post: | |
| type: object | ||
| example: | ||
| foo: bar | ||
| "*/*": | ||
| schema: {} | ||
| required: true | ||
| responses: | ||
| "201": | ||
|
|
||

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC the
PricingModelis no longer used anywhere, which means it won't be generated anymore (it's being removed, see: https://github.com/apify/apify-client-python/pull/707/changes).Is that correct?
We really don't need the enum anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is autogenerated based on errors produced by the integration tests. So as of now it is still part of the API. We can remove it from the specification in the future once it is completely removed from the API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this specifc file is no longer referenced anywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My point was whether the
PricingModelenum isn't used somewhere else in the Client or SDK.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used in SDK, but there it should be refactored. apify/apify-sdk-python#853