Open
Conversation
github-actions
Bot
added
the
t-core-services
|
Preview for this PR was built for commit |
tobice
requested review from
TC-MO,
nmanerikar and
raethlo
and removed request for
TC-MO
|
Preview for this PR was built for commit |
nmanerikar
approved these changes
Apr 29, 2026
Contributor
nmanerikar
left a comment
nmanerikar
left a comment
There was a problem hiding this comment.
Looks good!
Couple of small non-blocking comments.
TC-MO
approved these changes
Apr 30, 2026
Contributor
TC-MO
left a comment
TC-MO
left a comment
There was a problem hiding this comment.
Nothing major to fix, just some minor wording & a couple of opportunistic fixes
Co-authored-by: Nishad Manerikar <nmanerikar@yahoo.com> Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
tobice
commented
Apr 30, 2026
Contributor
Author
tobice
left a comment
tobice
left a comment
There was a problem hiding this comment.
Thanks everyone for the review!
|
Preview for this PR was built for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are about to launch forced approvals when running full-permission Actors. This PRs adds related documentation.
It also: