Skip to content

docs: fix secret image url#601

Merged
B4nan merged 3 commits intomasterfrom
fix/secret-input-image
May 26, 2023
Merged

docs: fix secret image url#601
B4nan merged 3 commits intomasterfrom
fix/secret-input-image

Conversation

@novotnyj
Copy link
Copy Markdown
Member

The image is png not jpg. Also other images are loaded using require, there is no @asset elsewhere in docs...

@github-actions github-actions bot added the t-c&c Team covering store and finance matters. label May 26, 2023
@novotnyj novotnyj added bug Something isn't working. adhoc Ad-hoc unplanned task added during the sprint. labels May 26, 2023
@novotnyj novotnyj requested a review from B4nan May 26, 2023 09:05

The editor for this input field will then turn into a secret input, and when you edit the field value, it will be stored encrypted.
<img src="{{@asset actors/development/images/secret-input-editor.jpg}}" alt="Secret input editor" style={{width: '100%', maxWidth: '822px'}}/>
<img src="{require("./images/secret-input-editor.png").default}" alt="Secret input editor" style="width: '100%'; max-width: 822px"/>
Copy link
Copy Markdown
Member

@B4nan B4nan May 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the part with style was correct, that needs to stay as it needs to be valid JSX, same for src, something like this should work

Suggested change
<img src="{require("./images/secret-input-editor.png").default}" alt="Secret input editor" style="width: '100%'; max-width: 822px"/>
<img src={require("./images/secret-input-editor.png").default} alt="Secret input editor" style={{width: '100%', maxWidth: '822px'}}/>

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, changed.

@B4nan B4nan changed the title fix: Fix secret image url docs: fix secret image url May 26, 2023
@B4nan B4nan merged commit dbfb967 into master May 26, 2023
@B4nan B4nan deleted the fix/secret-input-image branch May 26, 2023 10:54
@stetizu1 stetizu1 removed the t-c&c Team covering store and finance matters. label Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. bug Something isn't working.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants