Conversation
barjin
left a comment
There was a problem hiding this comment.
Note that these changes cause the sidebar not to render on the Changelog page, which imo looks a bit iffy (especially if you get there from any other page which has the sidebar layout).
I believe you can use the displayed_sidebar frontmatter field to enforce rendering the sidebar even if Changelog is not its item (docs).
|
Yup, thank you I made the same mistake over all PR's so will be fixing it across the board to enforce sidebar on changelog |
|
Question: can we unify the .gitignore approach? I applied the sidebar fix in CLI first (apify/apify-cli#1083) - wrapping the sidebar in a named export so we can use Applying the same fix here, I noticed this repo has multiple Could we consolidate to a single root |
|
If I recall correctly, we wanted to have the same changelog in all the docs versions (it's "versioned" by definition, and it might be confusing for the users to find an old version of the changelog with some versions missing). But if the docs team is fine with this (do we do this in CLI already?), it's fine, I guess. There's no deeper reason behind the multiple |
|
In CLI we had singular wait, unless I'm overthinking it? and the actual way is to just add |
That's what I would expect 👍 note that we likely don't want this directly in the changelog (might be weird for people viewing the changelog from outside of Docusaurus). Regarding the first part of your message - afaik we're currently not versioning changelog in SDK docs (https://docs.apify.com/sdk/js/docs/3.1/changelog is the same as https://docs.apify.com/sdk/js/docs/next/changelog)... and I thought we wanted that - but idk, you guys know more about DX :) |
|
Converting to draft for now |
No description provided.