Skip to content

Commit 405cf5d

Browse files
vdusekclaude
andauthored
fix: Correct inverted return value in Scrapy scheduler enqueue_request (#794)
## Summary - The `enqueue_request` method in `ApifyScheduler` was returning `bool(result.was_already_present)`, which incorrectly returned `True` for duplicates and `False` for newly enqueued requests - Per Scrapy's `BaseScheduler` contract, `enqueue_request` should return `True` when the request was **successfully stored** (new) and `False` when rejected (duplicate) - See https://docs.scrapy.org/en/latest/topics/scheduler.html#scrapy.core.scheduler.BaseScheduler.enqueue_request - One-line fix: `return not bool(result.was_already_present)` ## Test plan - [x] CI passes Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 61e3633 commit 405cf5d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/apify/scrapy/scheduler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ def enqueue_request(self, request: Request) -> bool:
136136
raise
137137

138138
logger.debug(f'rq.add_request result: {result}')
139-
return bool(result.was_already_present)
139+
return not bool(result.was_already_present)
140140

141141
def next_request(self) -> Request | None:
142142
"""Fetch the next request from the scheduler.

0 commit comments

Comments
 (0)