Skip to content

Commit 56cfc38

Browse files
vdusekclaude
andauthored
fix: pass name instead of id for name param in SmartApifyStorageClient (#775)
## Summary - All three `create_*_client` methods in `SmartApifyStorageClient` (`create_dataset_client`, `create_kvs_client`, `create_rq_client`) were passing `name=id` instead of `name=name` - This silently discarded the user-provided `name` argument and used the `id` value (often `None`) instead, breaking name-based storage opening entirely - Simple copy-paste fix: `name=id` -> `name=name` in all three methods ## Test plan - [ ] Verify existing tests pass - [ ] Test opening a storage by name via `SmartApifyStorageClient` and confirm it resolves to the correct named storage instead of default 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent fb13765 commit 56cfc38

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/apify/storage_clients/_smart_apify/_storage_client.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ async def create_dataset_client(
7474
configuration: CrawleeConfiguration | None = None,
7575
) -> DatasetClient:
7676
return await self.get_suitable_storage_client().create_dataset_client(
77-
id=id, name=id, alias=alias, configuration=configuration
77+
id=id, name=name, alias=alias, configuration=configuration
7878
)
7979

8080
@override
@@ -87,7 +87,7 @@ async def create_kvs_client(
8787
configuration: CrawleeConfiguration | None = None,
8888
) -> KeyValueStoreClient:
8989
return await self.get_suitable_storage_client().create_kvs_client(
90-
id=id, name=id, alias=alias, configuration=configuration
90+
id=id, name=name, alias=alias, configuration=configuration
9191
)
9292

9393
@override
@@ -100,7 +100,7 @@ async def create_rq_client(
100100
configuration: CrawleeConfiguration | None = None,
101101
) -> RequestQueueClient:
102102
return await self.get_suitable_storage_client().create_rq_client(
103-
id=id, name=id, alias=alias, configuration=configuration
103+
id=id, name=name, alias=alias, configuration=configuration
104104
)
105105

106106
def get_suitable_storage_client(self, *, force_cloud: bool = False) -> StorageClient:

0 commit comments

Comments
 (0)