Commit 5bd6eb9
authored
fix(scrapy): correct proxy middleware exception log and import (#953)
Fixes in `ApifyHttpProxyMiddleware`:
- `process_exception` logged `reason="{exception}"` verbatim because the
second line of the message was not an f-string; the actual exception is
now interpolated.
- Removed the docstring for a non-existent `auth_encoding` argument.
- Import `get_basic_auth_header` directly from `apify.scrapy.utils`
instead of via the package `__init__` (which is `try_import`-order
fragile).1 parent c4502b6 commit 5bd6eb9
1 file changed
Lines changed: 2 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
34 | 33 | | |
35 | 34 | | |
36 | 35 | | |
| |||
111 | 110 | | |
112 | 111 | | |
113 | 112 | | |
114 | | - | |
| 113 | + | |
115 | 114 | | |
116 | 115 | | |
117 | 116 | | |
| |||
0 commit comments