Skip to content

Commit 97992ed

Browse files
committed
Fix tests
1 parent ecb5a51 commit 97992ed

14 files changed

+89
-71
lines changed

tests/integration/actor/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ async def _make_actor(
230230
{
231231
'versionNumber': '0.0',
232232
'buildTag': 'latest',
233-
'sourceType': VersionSourceType.SOURCE_FILES,
233+
'sourceType': VersionSourceType.SOURCE_FILES.value,
234234
'sourceFiles': source_files_for_api,
235235
}
236236
],

tests/integration/actor/test_actor_api_helpers.py

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import json
55
from typing import TYPE_CHECKING
66

7-
from apify_client._models import ActorPermissionLevel
7+
from apify_client._models import ActorJobStatus, ActorPermissionLevel
88
from crawlee._utils.crypto import crypto_random_object_id
99

1010
from .._utils import generate_unique_resource_name
@@ -28,7 +28,7 @@ async def main() -> None:
2828
actor = await make_actor(label='is-at-home', main_func=main)
2929
run_result = await run_actor(actor)
3030

31-
assert run_result.status == 'SUCCEEDED'
31+
assert run_result.status == ActorJobStatus.SUCCEEDED
3232

3333

3434
async def test_actor_retrieves_env_vars(
@@ -52,7 +52,7 @@ async def main() -> None:
5252
actor = await make_actor(label='get-env', main_func=main)
5353
run_result = await run_actor(actor)
5454

55-
assert run_result.status == 'SUCCEEDED'
55+
assert run_result.status == ActorJobStatus.SUCCEEDED
5656

5757

5858
async def test_actor_creates_new_client_instance(
@@ -76,7 +76,7 @@ async def main() -> None:
7676
actor = await make_actor(label='new-client', main_func=main)
7777
run_result = await run_actor(actor)
7878

79-
assert run_result.status == 'SUCCEEDED'
79+
assert run_result.status == ActorJobStatus.SUCCEEDED
8080

8181
output_record = await actor.last_run().key_value_store().get_record('OUTPUT')
8282
assert output_record is not None
@@ -95,13 +95,13 @@ async def main() -> None:
9595
actor = await make_actor(label='set-status-message', main_func=main)
9696
run_result_1 = await run_actor(actor)
9797

98-
assert run_result_1.status == 'SUCCEEDED'
98+
assert run_result_1.status == ActorJobStatus.SUCCEEDED
9999
assert run_result_1.status_message == 'testing-status-message'
100100
assert run_result_1.is_status_message_terminal is None
101101

102102
run_result_2 = await run_actor(actor, run_input={'is_terminal': True})
103103

104-
assert run_result_2.status == 'SUCCEEDED'
104+
assert run_result_2.status == ActorJobStatus.SUCCEEDED
105105
assert run_result_2.status_message == 'testing-status-message'
106106
assert run_result_2.is_status_message_terminal is True
107107

@@ -145,7 +145,7 @@ async def main_outer() -> None:
145145
run_input={'test_value': test_value, 'inner_actor_id': inner_actor_id},
146146
)
147147

148-
assert run_result_outer.status == 'SUCCEEDED'
148+
assert run_result_outer.status == ActorJobStatus.SUCCEEDED
149149

150150
await inner_actor.last_run().wait_for_finish(wait_secs=600)
151151

@@ -177,7 +177,7 @@ async def main_outer() -> None:
177177

178178
inner_run_status = await Actor.apify_client.actor(inner_actor_id).last_run().get()
179179
assert inner_run_status is not None
180-
assert inner_run_status.status == 'SUCCEEDED'
180+
assert inner_run_status.status == ActorJobStatus.SUCCEEDED
181181

182182
inner_actor = await make_actor(label='call-inner', main_func=main_inner)
183183
outer_actor = await make_actor(label='call-outer', main_func=main_outer)
@@ -193,7 +193,7 @@ async def main_outer() -> None:
193193
run_input={'test_value': test_value, 'inner_actor_id': inner_actor_id},
194194
)
195195

196-
assert run_result_outer.status == 'SUCCEEDED'
196+
assert run_result_outer.status == ActorJobStatus.SUCCEEDED
197197

198198
await inner_actor.last_run().wait_for_finish(wait_secs=600)
199199

@@ -225,7 +225,7 @@ async def main_outer() -> None:
225225

226226
inner_run_status = await Actor.apify_client.task(inner_task_id).last_run().get()
227227
assert inner_run_status is not None
228-
assert inner_run_status.status == 'SUCCEEDED'
228+
assert inner_run_status.status == ActorJobStatus.SUCCEEDED
229229

230230
inner_actor = await make_actor(label='call-task-inner', main_func=main_inner)
231231
outer_actor = await make_actor(label='call-task-outer', main_func=main_outer)
@@ -248,7 +248,7 @@ async def main_outer() -> None:
248248
force_permission_level=ActorPermissionLevel.FULL_PERMISSIONS,
249249
)
250250

251-
assert run_result_outer.status == 'SUCCEEDED'
251+
assert run_result_outer.status == ActorJobStatus.SUCCEEDED
252252

253253
await inner_actor.last_run().wait_for_finish(wait_secs=600)
254254

@@ -290,7 +290,7 @@ async def main_outer() -> None:
290290
force_permission_level=ActorPermissionLevel.FULL_PERMISSIONS,
291291
)
292292

293-
assert run_result_outer.status == 'SUCCEEDED'
293+
assert run_result_outer.status == ActorJobStatus.SUCCEEDED
294294

295295
inner_actor_run_client = inner_actor.last_run()
296296
inner_actor_run = await inner_actor_run_client.wait_for_finish(wait_secs=600)
@@ -301,7 +301,7 @@ async def main_outer() -> None:
301301
inner_actor_run_dict = inner_actor_run.model_dump(by_alias=True)
302302
inner_actor_last_run = ActorRun.model_validate(inner_actor_run_dict)
303303

304-
assert inner_actor_last_run.status == 'ABORTED'
304+
assert inner_actor_last_run.status == ActorJobStatus.ABORTED
305305

306306
inner_output_record = await inner_actor.last_run().key_value_store().get_record('OUTPUT')
307307
assert inner_output_record is None
@@ -356,7 +356,7 @@ async def main_outer() -> None:
356356
run_input={'test_value': test_value, 'inner_actor_id': inner_actor_id},
357357
)
358358

359-
assert run_result_outer.status == 'SUCCEEDED'
359+
assert run_result_outer.status == ActorJobStatus.SUCCEEDED
360360

361361
outer_run_key_value_store = outer_actor.last_run().key_value_store()
362362

@@ -394,7 +394,7 @@ async def main() -> None:
394394
run_input={'counter_key': 'reboot_counter'},
395395
)
396396

397-
assert run_result.status == 'SUCCEEDED'
397+
assert run_result.status == ActorJobStatus.SUCCEEDED
398398

399399
not_written_value = await actor.last_run().key_value_store().get_record('THIS_KEY_SHOULD_NOT_BE_WRITTEN')
400400
assert not_written_value is None
@@ -473,7 +473,7 @@ async def main_client() -> None:
473473
run_input={'server_actor_container_url': server_actor_container_url},
474474
)
475475

476-
assert ac_run_result.status == 'SUCCEEDED'
476+
assert ac_run_result.status == ActorJobStatus.SUCCEEDED
477477

478478
sa_run_client = server_actor.last_run()
479479
sa_run_client_run = await sa_run_client.wait_for_finish(wait_secs=600)
@@ -484,7 +484,7 @@ async def main_client() -> None:
484484
sa_run_client_run_dict = sa_run_client_run.model_dump(by_alias=True)
485485
sa_run_result = ActorRun.model_validate(sa_run_client_run_dict)
486486

487-
assert sa_run_result.status == 'SUCCEEDED'
487+
assert sa_run_result.status == ActorJobStatus.SUCCEEDED
488488

489489
webhook_body_record = await server_actor.last_run().key_value_store().get_record('WEBHOOK_BODY')
490490
assert webhook_body_record is not None

tests/integration/actor/test_actor_call_timeouts.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
import asyncio
44
from typing import TYPE_CHECKING
55

6+
from apify_client._models import ActorJobStatus
7+
68
from apify import Actor
79

810
if TYPE_CHECKING:
@@ -53,7 +55,7 @@ async def main() -> None:
5355
actor = await make_actor(label='inherit-timeout', main_func=main)
5456
run_result = await run_actor(actor)
5557

56-
assert run_result.status == 'SUCCEEDED'
58+
assert run_result.status == ActorJobStatus.SUCCEEDED
5759

5860

5961
async def test_actor_call_inherit_timeout(
@@ -102,4 +104,4 @@ async def main() -> None:
102104
actor = await make_actor(label='remaining-timeout', main_func=main)
103105
run_result = await run_actor(actor)
104106

105-
assert run_result.status == 'SUCCEEDED'
107+
assert run_result.status == ActorJobStatus.SUCCEEDED

tests/integration/actor/test_actor_create_proxy_configuration.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
from typing import TYPE_CHECKING
44

5+
from apify_client._models import ActorJobStatus
6+
57
from apify import Actor
68

79
if TYPE_CHECKING:
@@ -30,7 +32,7 @@ async def main() -> None:
3032
actor = await make_actor(label='proxy-configuration', main_func=main)
3133
run_result = await run_actor(actor)
3234

33-
assert run_result.status == 'SUCCEEDED'
35+
assert run_result.status == ActorJobStatus.SUCCEEDED
3436

3537

3638
async def test_create_proxy_configuration_with_groups_and_country(
@@ -70,4 +72,4 @@ async def main() -> None:
7072
actor = await make_actor(label='proxy-configuration', main_func=main)
7173
run_result = await run_actor(actor)
7274

73-
assert run_result.status == 'SUCCEEDED'
75+
assert run_result.status == ActorJobStatus.SUCCEEDED

tests/integration/actor/test_actor_dataset.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
from typing import TYPE_CHECKING
44

5+
from apify_client._models import ActorJobStatus
56
from apify_shared.consts import ApifyEnvVars
67

78
from .._utils import generate_unique_resource_name
@@ -29,7 +30,7 @@ async def main() -> None:
2930
actor = await make_actor(label='push-data', main_func=main)
3031
run_result = await run_actor(actor)
3132

32-
assert run_result.status == 'SUCCEEDED'
33+
assert run_result.status == ActorJobStatus.SUCCEEDED
3334

3435
list_page = await actor.last_run().dataset().list_items()
3536
assert list_page.items[0]['id'] == 0
@@ -48,7 +49,7 @@ async def main() -> None:
4849
actor = await make_actor(label='push-data-over-9mb', main_func=main)
4950
run_result = await run_actor(actor)
5051

51-
assert run_result.status == 'SUCCEEDED'
52+
assert run_result.status == ActorJobStatus.SUCCEEDED
5253

5354
async for item in actor.last_run().dataset().iterate_items():
5455
assert item['str'] == 'x' * 10000
@@ -71,7 +72,7 @@ async def main() -> None:
7172

7273
actor = await make_actor(label='test_dataset_iter_items', main_func=main)
7374
run_result = await run_actor(actor)
74-
assert run_result.status == 'SUCCEEDED'
75+
assert run_result.status == ActorJobStatus.SUCCEEDED
7576

7677

7778
async def test_same_references_in_default_dataset(
@@ -87,7 +88,7 @@ async def main() -> None:
8788
actor = await make_actor(label='dataset-same-ref-default', main_func=main)
8889
run_result = await run_actor(actor)
8990

90-
assert run_result.status == 'SUCCEEDED'
91+
assert run_result.status == ActorJobStatus.SUCCEEDED
9192

9293

9394
async def test_same_references_in_named_dataset(
@@ -115,7 +116,7 @@ async def main() -> None:
115116
actor = await make_actor(label='dataset-same-ref-named', main_func=main)
116117
run_result = await run_actor(actor, run_input={'datasetName': dataset_name})
117118

118-
assert run_result.status == 'SUCCEEDED'
119+
assert run_result.status == ActorJobStatus.SUCCEEDED
119120

120121

121122
async def test_force_cloud(
@@ -183,7 +184,7 @@ async def main() -> None:
183184
actor = await make_actor(label='dataset-defaults', main_func=main)
184185
run_result = await run_actor(actor)
185186

186-
assert run_result.status == 'SUCCEEDED'
187+
assert run_result.status == ActorJobStatus.SUCCEEDED
187188

188189

189190
async def test_dataset_aliases(
@@ -227,4 +228,4 @@ async def main() -> None:
227228
actor = await make_actor(label='dataset-aliases', main_func=main)
228229
run_result = await run_actor(actor)
229230

230-
assert run_result.status == 'SUCCEEDED'
231+
assert run_result.status == ActorJobStatus.SUCCEEDED

tests/integration/actor/test_actor_events.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import asyncio
44
from typing import TYPE_CHECKING
55

6+
from apify_client._models import ActorJobStatus
67
from apify_shared.consts import ActorEventTypes
78

89
from apify import Actor
@@ -60,7 +61,7 @@ async def log_event(data: Any) -> None:
6061
actor = await make_actor(label='actor-interval-events', main_func=main)
6162
run_result = await run_actor(actor)
6263

63-
assert run_result.status == 'SUCCEEDED'
64+
assert run_result.status == ActorJobStatus.SUCCEEDED
6465

6566
dataset_items_page = await actor.last_run().dataset().list_items()
6667
persist_state_events = [
@@ -105,4 +106,4 @@ def count_event(data: Any) -> None:
105106
actor = await make_actor(label='actor-off-event', main_func=main)
106107
run_result = await run_actor(actor)
107108

108-
assert run_result.status == 'SUCCEEDED'
109+
assert run_result.status == ActorJobStatus.SUCCEEDED

tests/integration/actor/test_actor_key_value_store.py

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
from typing import TYPE_CHECKING
44

5+
from apify_client._models import ActorJobStatus
56
from apify_shared.consts import ApifyEnvVars
67

78
from .._utils import generate_unique_resource_name
@@ -28,7 +29,7 @@ async def main() -> None:
2829
actor = await make_actor(label='kvs-same-ref-default', main_func=main)
2930
run_result = await run_actor(actor)
3031

31-
assert run_result.status == 'SUCCEEDED'
32+
assert run_result.status == ActorJobStatus.SUCCEEDED
3233

3334

3435
async def test_same_references_in_named_kvs(
@@ -56,7 +57,7 @@ async def main() -> None:
5657
actor = await make_actor(label='kvs-same-ref-named', main_func=main)
5758
run_result = await run_actor(actor, run_input={'kvsName': kvs_name})
5859

59-
assert run_result.status == 'SUCCEEDED'
60+
assert run_result.status == ActorJobStatus.SUCCEEDED
6061

6162

6263
async def test_force_cloud(
@@ -103,7 +104,7 @@ async def main() -> None:
103104
actor = await make_actor(label='actor-get-set-value', main_func=main)
104105
run_result = await run_actor(actor)
105106

106-
assert run_result.status == 'SUCCEEDED'
107+
assert run_result.status == ActorJobStatus.SUCCEEDED
107108

108109

109110
async def test_set_value_in_one_run_and_get_value_in_another(
@@ -117,7 +118,7 @@ async def main_set() -> None:
117118
actor_set = await make_actor(label='actor-set-value', main_func=main_set)
118119
run_result_set = await run_actor(actor_set)
119120

120-
assert run_result_set.status == 'SUCCEEDED'
121+
assert run_result_set.status == ActorJobStatus.SUCCEEDED
121122

122123
# Externally check if the value is present in key-value store
123124
test_record = await actor_set.last_run().key_value_store().get_record('test')
@@ -143,7 +144,7 @@ async def main_get() -> None:
143144

144145
run_result_get = await run_actor(actor_get, run_input={'kvs-id': default_kvs_info.id})
145146

146-
assert run_result_get.status == 'SUCCEEDED'
147+
assert run_result_get.status == ActorJobStatus.SUCCEEDED
147148

148149

149150
async def test_actor_get_input_from_run(
@@ -194,7 +195,7 @@ async def main():
194195
},
195196
)
196197

197-
assert run_result.status == 'SUCCEEDED'
198+
assert run_result.status == ActorJobStatus.SUCCEEDED
198199

199200

200201
async def test_generate_public_url_for_kvs_record(
@@ -229,7 +230,7 @@ async def main() -> None:
229230
actor = await make_actor(label='kvs-get-public-url', main_func=main)
230231
run_result = await run_actor(actor)
231232

232-
assert run_result.status == 'SUCCEEDED'
233+
assert run_result.status == ActorJobStatus.SUCCEEDED
233234

234235

235236
async def test_kvs_defaults(
@@ -268,7 +269,7 @@ async def main() -> None:
268269
actor = await make_actor(label='kvs-defaults', main_func=main)
269270
run_result = await run_actor(actor)
270271

271-
assert run_result.status == 'SUCCEEDED'
272+
assert run_result.status == ActorJobStatus.SUCCEEDED
272273

273274

274275
async def test_kvs_aliases(
@@ -312,4 +313,4 @@ async def main() -> None:
312313
actor = await make_actor(label='kvs-aliases', main_func=main)
313314
run_result = await run_actor(actor)
314315

315-
assert run_result.status == 'SUCCEEDED'
316+
assert run_result.status == ActorJobStatus.SUCCEEDED

0 commit comments

Comments
 (0)