refactor: Address review comments

Author: vdusek

src/apify/_actor.py

@@ -926,7 +926,7 @@ async def start(
             raise ValueError(f'Invalid timeout {timeout!r}: expected `None`, `"inherit"`, or a `timedelta`.')
 
         actor_client = client.actor(actor_id)
-        run = await actor_client.start(
+        return await actor_client.start(
             run_input=run_input,
             content_type=content_type,
             build=build,
@@ -939,11 +939,6 @@ async def start(
             webhooks=to_client_representations(webhooks),
         )
 
-        if run is None:
-            raise RuntimeError(f'Failed to start Actor with ID "{actor_id}".')
-
-        return run
-
     @_ensure_context
     async def abort(
         self,

src/apify/_charging.py

@@ -40,7 +40,7 @@
 _ensure_context = ensure_context('active')
 
 
-# --- SDK-side Actor pricing-info models ---------------------------------------------------------------
+# SDK-side Actor pricing-info models.
 #
 # These are thin subclasses of the `apify-client` pricing models. The Apify platform serializes Actor
 # pricing info into the `APIFY_ACTOR_PRICING_INFO` env var (parsed by `Configuration.actor_pricing_info`),

src/apify/_consts.py

@@ -7,14 +7,17 @@
 EVENT_LISTENERS_TIMEOUT = timedelta(seconds=5)
 """Timeout for waiting on event listeners to finish during Actor exit."""
 
+BASE64_REGEXP = '[-A-Za-z0-9+/]*={0,3}'
+"""Regex fragment matching a single base64-encoded component."""
+
 ENCRYPTED_STRING_VALUE_PREFIX = 'ENCRYPTED_VALUE'
 """Prefix for encrypted string values in Actor input."""
 
 ENCRYPTED_JSON_VALUE_PREFIX = 'ENCRYPTED_JSON'
 """Prefix for encrypted JSON values in Actor input."""
 
 ENCRYPTED_INPUT_VALUE_REGEXP = re.compile(
-    r'^(ENCRYPTED_VALUE|ENCRYPTED_JSON):(?:([-A-Za-z0-9+/]*={0,3}):)?([-A-Za-z0-9+/]*={0,3}):([-A-Za-z0-9+/]*={0,3})$'
+    f'^({ENCRYPTED_STRING_VALUE_PREFIX}|{ENCRYPTED_JSON_VALUE_PREFIX}):(?:({BASE64_REGEXP}):)?({BASE64_REGEXP}):({BASE64_REGEXP})$'
 )
 """Regex matching encrypted input values with base64-encoded components."""
 

src/apify/storage_clients/_apify/_alias_resolving.py

@@ -2,7 +2,6 @@
 
 import logging
 from asyncio import Lock
-from datetime import timedelta
 from functools import cached_property
 from logging import getLogger
 from typing import TYPE_CHECKING, ClassVar, Literal, overload
@@ -258,7 +257,6 @@ async def _get_default_kvs_client(configuration: Configuration) -> KeyValueStore
             token=configuration.token,
             api_url=configuration.api_base_url,
             max_retries=8,
-            min_delay_between_retries=timedelta(milliseconds=500),
         )
 
         if not configuration.default_key_value_store_id:

src/apify/storage_clients/_apify/_api_client_creation.py

@@ -1,6 +1,5 @@
 from __future__ import annotations
 
-from datetime import timedelta
 from typing import TYPE_CHECKING, Literal, overload
 
 from apify_client import ApifyClientAsync
@@ -178,5 +177,4 @@ def _create_api_client(configuration: Configuration) -> ApifyClientAsync:
         api_url=configuration.api_base_url,
         api_public_url=configuration.api_public_base_url,
         max_retries=8,
-        min_delay_between_retries=timedelta(milliseconds=500),
     )

tests/e2e/conftest.py

@@ -48,10 +48,9 @@ def apify_token() -> str:
 def apify_client_async(apify_token: str) -> ApifyClientAsync:
     """Create an instance of the ApifyClientAsync."""
     api_url = os.getenv(_API_URL_ENV_VAR)
-
-    if api_url is not None:
-        return ApifyClientAsync(apify_token, api_url=api_url)
-    return ApifyClientAsync(apify_token)
+    return (
+        ApifyClientAsync(token=apify_token) if api_url is None else ApifyClientAsync(token=apify_token, api_url=api_url)
+    )
 
 
 @pytest.fixture