Commit b807c69
fix: stop silently swallowing exceptions in RQ mark_request_as_handled and reclaim_request
Both the single and shared request queue clients caught all exceptions
in `mark_request_as_handled` and `reclaim_request`, logged them at
DEBUG level, and returned `None`. This made it impossible for callers
to distinguish between "request was not in progress" (legitimate None
per the base class contract) and "API call failed" (swallowed error).
Silently swallowing errors also meant metadata counters could drift
from platform state without any visible indication of the problem.
Remove the catch-all `except Exception` blocks and let exceptions
propagate naturally so callers can handle failures appropriately.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>1 parent 56aa42e commit b807c69
File tree
2 files changed
+8
-8
lines changed- src/apify/storage_clients/_apify
2 files changed
+8
-8
lines changedLines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
235 | 235 | | |
236 | 236 | | |
237 | 237 | | |
238 | | - | |
239 | | - | |
| 238 | + | |
| 239 | + | |
240 | 240 | | |
241 | 241 | | |
242 | 242 | | |
| |||
279 | 279 | | |
280 | 280 | | |
281 | 281 | | |
282 | | - | |
283 | | - | |
| 282 | + | |
| 283 | + | |
284 | 284 | | |
285 | 285 | | |
286 | 286 | | |
| |||
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
220 | 220 | | |
221 | 221 | | |
222 | 222 | | |
223 | | - | |
224 | | - | |
| 223 | + | |
| 224 | + | |
225 | 225 | | |
226 | 226 | | |
227 | 227 | | |
| |||
263 | 263 | | |
264 | 264 | | |
265 | 265 | | |
266 | | - | |
267 | | - | |
| 266 | + | |
| 267 | + | |
268 | 268 | | |
269 | 269 | | |
270 | 270 | | |
| |||
0 commit comments