test: revert unnecessary changes to test_actor_log.py

The original strict assertions (exact count, initialization log messages,
index-based ordering) are valid and more thorough.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: vdusek

tests/unit/actor/test_actor_log.py

@@ -38,7 +38,15 @@ async def test_actor_logs_messages_correctly(caplog: pytest.LogCaptureFixture) -
 
     records = caplog.records
 
+    # Expected number of log records
+    assert len(records) == 13
+
     expected_logs = [
+        (logging.INFO, 'Initializing Actor'),
+        (logging.DEBUG, 'Configuration initialized'),
+        (logging.DEBUG, 'Storage client initialized'),
+        (logging.DEBUG, 'Event manager initialized'),
+        (logging.DEBUG, 'Charging manager initialized'),
         (logging.DEBUG, 'Debug message'),
         (logging.INFO, 'Info message'),
         (logging.WARNING, 'Warning message'),
@@ -50,10 +58,9 @@ async def test_actor_logs_messages_correctly(caplog: pytest.LogCaptureFixture) -
     ]
 
     for level, message, *exception in expected_logs:
-        matching = [r for r in records if r.message == message]
-        assert len(matching) == 1, f'Expected exactly one log record with message {message!r}, found {len(matching)}'
-        record = matching[0]
+        record = records.pop(0)
         assert record.levelno == level
+        assert record.message == message
         if exception:
             assert record.exc_info is not None
             assert record.exc_info[0] is type(exception[0])

tests/unit/actor/test_configuration.py

@@ -243,11 +243,19 @@ def test_apify_configuration_is_always_used(caplog: pytest.LogCaptureFixture) ->
     ) in caplog.messages
 
 
-def test_token_from_env_var(monkeypatch: pytest.MonkeyPatch) -> None:
-    """Test that token is populated from APIFY_TOKEN env var."""
+def test_env_vars_populate_correctly(monkeypatch: pytest.MonkeyPatch) -> None:
+    """Test that configuration values are populated from environment variables."""
     monkeypatch.setenv('APIFY_TOKEN', 'my-test-token')
+    monkeypatch.setenv('APIFY_ACTOR_ID', 'actor-123')
+    monkeypatch.setenv('APIFY_ACT_RUN_ID', 'run-456')
+    monkeypatch.setenv('APIFY_IS_AT_HOME', '1')
+    monkeypatch.setenv('APIFY_API_BASE_URL', 'https://custom-api.apify.com')
     config = ApifyConfiguration()
     assert config.token == 'my-test-token'
+    assert config.actor_id == 'actor-123'
+    assert config.actor_run_id == 'run-456'
+    assert config.is_at_home is True
+    assert config.api_base_url == 'https://custom-api.apify.com'
 
 
 def test_default_values() -> None:
@@ -266,19 +274,6 @@ def test_default_values() -> None:
     assert config.test_pay_per_event is False
 
 
-def test_env_var_aliases_populate_correctly(monkeypatch: pytest.MonkeyPatch) -> None:
-    """Test that env var aliases are resolved correctly."""
-    monkeypatch.setenv('APIFY_ACTOR_ID', 'actor-123')
-    monkeypatch.setenv('APIFY_ACT_RUN_ID', 'run-456')
-    monkeypatch.setenv('APIFY_IS_AT_HOME', '1')
-    monkeypatch.setenv('APIFY_API_BASE_URL', 'https://custom-api.apify.com')
-    config = ApifyConfiguration()
-    assert config.actor_id == 'actor-123'
-    assert config.actor_run_id == 'run-456'
-    assert config.is_at_home is True
-    assert config.api_base_url == 'https://custom-api.apify.com'
-
-
 def test_max_total_charge_usd_decimal_parsing(monkeypatch: pytest.MonkeyPatch) -> None:
     """Test that max_total_charge_usd is parsed as Decimal from env var."""
     from decimal import Decimal

tests/unit/test_crypto.py

@@ -112,7 +112,7 @@ def test_crypto_random_object_id_length_and_charset() -> None:
     assert len(crypto_random_object_id(5)) == 5
     long_random_object_id = crypto_random_object_id(1000)
     for char in long_random_object_id:
-        assert char in '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ'
+        assert char in 'abcdefghijklmnopqrstuvwxyzABCEDFGHIJKLMNOPQRSTUVWXYZ0123456789'
 
 
 @pytest.mark.parametrize(('test_input', 'expected'), [(0, '0'), (10, 'a'), (999999999, '15FTGf')])