test: Fix Actor logging integration test#709
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #709 +/- ##
=======================================
Coverage 82.00% 82.00%
=======================================
Files 46 46
Lines 2679 2679
=======================================
Hits 2197 2197
Misses 482 482
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
871397a to
ce3e726
Compare
ce3e726 to
73c2ce3
Compare
| full_log = '\n'.join(run_log_lines) | ||
|
|
||
| # Verify expected log messages are present (order-independent checks) | ||
| assert '[apify] DEBUG Debug message' in full_log |
There was a problem hiding this comment.
I will allow this. Honestly, I'd be fine if you just removed this test 😄
There was a problem hiding this comment.
Well, the logging can be problematic due to our custom configuration in Actor -> https://github.com/apify/apify-sdk-python/blob/master/src/apify/_actor.py#L169-L172 . We already had cases with log statements before configure_logging, which were supposed to log info messages, but it wasn't working, and this went unnoticed for a long time. Because of that, I would prefer to keep this test :).
Uh oh!
There was an error while loading. Please reload this page.