Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #739 +/- ##
=======================================
Coverage 81.98% 81.98%
=======================================
Files 46 46
Lines 2681 2681
=======================================
Hits 2198 2198
Misses 483 483
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running integration tests created random-named directories (e.g.,
41SJFVD7V6,KEIN9WBF32) in the project root instead of using temporary directories.Root cause
The main
tests/integration/conftest.pywas missing theprepare_test_envfixture that setsAPIFY_LOCAL_STORAGE_DIRto a pytest-managed temporary directory. Without this, Crawlee's default behavior creates randomly-named directories in the current working directory.Changes
Added
prepare_test_envfixture totests/integration/conftest.pyAPIFY_LOCAL_STORAGE_DIRtotmp_path_isolate_test_environment(autouse=True)Removed duplicate
tests/integration/apify_api/conftest.pyTesting
After this fix, all storage directories are created under pytest's temporary directory and automatically cleaned up after test runs.
🤖 Generated with Claude Code