Skip to content

fix: Resolve LogRecord attribute conflict in event manager logging #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 2 commits into from
Feb 18, 2026
Merged

fix: Resolve LogRecord attribute conflict in event manager logging #802

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbffc9e
fix: Resolve LogRecord attribute conflict in event manager logging
vdusek Feb 18, 2026
f85094c
Merge branch 'master' into fix/event-manager-logging-conflicts
vdusek Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/apify/events/_apify_event_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ async def _process_platform_messages(self, ws_url: str) -> None:
await self._emit_persist_state_event_rec_task.stop()
self.emit(event=Event.PERSIST_STATE, event_data=EventPersistStateData(is_migrating=True))
except Exception:
logger.exception('Cannot parse Actor event', extra={'message': message})
logger.exception('Cannot parse Actor event', extra={'raw_message': message})
except Exception:
logger.exception('Error in websocket connection')
if self._connected_to_platform_websocket is not None:
Expand Down
1 change: 1 addition & 0 deletions tests/unit/events/test_apify_event_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,7 @@ def listener(data: Any) -> None:

async def test_unknown_event_is_logged(monkeypatch: pytest.MonkeyPatch, caplog: pytest.LogCaptureFixture) -> None:
"""Test that unknown events are logged and not emitted."""
caplog.set_level(logging.INFO, logger='apify')
connected_ws_clients: set[websockets.asyncio.server.ServerConnection] = set()

async def handler(websocket: websockets.asyncio.server.ServerConnection) -> None:
Expand Down