Skip to content

fix: Treat default alias as default storage when in schema#827

Merged
Pijukatel merged 3 commits intomasterfrom
read-default-from-config
Mar 26, 2026
Merged

fix: Treat default alias as default storage when in schema#827
Pijukatel merged 3 commits intomasterfrom
read-default-from-config

Conversation

@Pijukatel
Copy link
Copy Markdown
Contributor

@Pijukatel Pijukatel commented Mar 10, 2026

Treat default alias as default storage when in schema.
To be aligned with the new JS implementation and match the platform users' expectations.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.44%. Comparing base (c6ff75c) to head (082100d).
⚠️ Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #827      +/-   ##
==========================================
+ Coverage   85.90%   86.44%   +0.53%     
==========================================
  Files          46       48       +2     
  Lines        2796     2900     +104     
==========================================
+ Hits         2402     2507     +105     
+ Misses        394      393       -1     
Flag Coverage Δ
e2e 38.13% <66.66%> (+0.08%) ⬆️
integration 59.58% <100.00%> (+0.21%) ⬆️
unit 74.41% <100.00%> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added this to the 136th sprint - Tooling team milestone Mar 11, 2026
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Mar 11, 2026
@Pijukatel Pijukatel force-pushed the read-default-from-config branch from 3062146 to 7efd37f Compare March 11, 2026 15:30
@Pijukatel Pijukatel force-pushed the read-default-from-config branch from 3a7c2b0 to 082100d Compare March 13, 2026 10:37
@Pijukatel Pijukatel added the adhoc Ad-hoc unplanned task added during the sprint. label Mar 13, 2026
@Pijukatel Pijukatel changed the title chore: Treat default alias as default storage chore: Treat default alias as default storage when in schema Mar 13, 2026
@Pijukatel Pijukatel marked this pull request as ready for review March 16, 2026 10:05
Copy link
Copy Markdown
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This affects public API behavior, so it should not be a chore, IMO.

@Pijukatel Pijukatel changed the title chore: Treat default alias as default storage when in schema feat: Treat default alias as default storage when in schema Mar 23, 2026
@Pijukatel Pijukatel requested a review from vdusek March 23, 2026 06:57
@vdusek vdusek changed the title feat: Treat default alias as default storage when in schema fix: Treat default alias as default storage when in schema Mar 26, 2026
Copy link
Copy Markdown
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it should be labeled as a "fix" as stated in the description:

To be aligned with the new JS implementation and match the platform users' expectations.

Otherwise, LGTM 👍.

@Pijukatel Pijukatel merged commit 1610d0d into master Mar 26, 2026
31 of 32 checks passed
@Pijukatel Pijukatel deleted the read-default-from-config branch March 26, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants