Skip to content

fix: Handle exceptions in pre-reboot event listeners via return_exceptions #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 2 commits into from
Mar 27, 2026
Merged

fix: Handle exceptions in pre-reboot event listeners via return_exceptions #843

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
526af53
fix: Handle exceptions in pre-reboot event listeners via `return_exce…
vdusek Mar 26, 2026
0d154ca
add test
vdusek Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/apify/_actor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1194,11 +1194,16 @@ async def reboot(
(self.event_manager._listeners_to_wrappers[Event.MIGRATING] or {}).values() # noqa: SLF001
)

await asyncio.gather(
results = await asyncio.gather(
*[listener(EventPersistStateData(is_migrating=True)) for listener in persist_state_listeners],
*[listener(EventMigratingData()) for listener in migrating_listeners],
return_exceptions=True,
)

for result in results:
if isinstance(result, Exception):
self.log.exception('A pre-reboot event listener failed', exc_info=result)

if not self.configuration.actor_run_id:
raise RuntimeError('actor_run_id cannot be None when running on the Apify platform.')

Expand Down
Loading