Conversation
B4nan
force-pushed
the
chore/migrate-to-oxlint
branch
from
ffdc7aa to
e672ad1
Compare
B4nan
force-pushed
the
chore/migrate-to-oxfmt
branch
from
a266d0c to
ba9de19
Compare
B4nan
force-pushed
the
chore/migrate-to-oxlint
branch
from
e672ad1 to
033d72f
Compare
B4nan
force-pushed
the
chore/migrate-to-oxfmt
branch
from
ba9de19 to
4ca03b8
Compare
B4nan
force-pushed
the
chore/migrate-to-oxlint
branch
from
033d72f to
a60c280
Compare
B4nan
force-pushed
the
chore/migrate-to-oxfmt
branch
from
4ca03b8 to
26d3237
Compare
B4nan
force-pushed
the
chore/migrate-to-oxlint
branch
from
a60c280 to
bc21bd5
Compare
B4nan
force-pushed
the
chore/migrate-to-oxfmt
branch
from
26d3237 to
5285134
Compare
B4nan
force-pushed
the
chore/migrate-to-oxlint
branch
2 times, most recently
from
6898006 to
c8e3902
Compare
Adds the oxfmt formatter (devDep + .oxfmtrc.json), `format` / `format:check` scripts, and wires `oxfmt --write` into lint-staged so new commits stay formatted. The CI format-check job and the actual reformat are added in follow-up commits.
Run `oxfmt --write` across the whole repo. Pure formatting commit; no behavior change. Folded in is one directive move from `// eslint-disable-line` on the body of a `for-in` to `// eslint-disable-next-line` above the loop, since oxfmt split the trailing comment onto the next line which made it apply to the wrong statement.
Adds a `format-check` job that runs `pnpm format:check` (oxfmt) on every PR and gates the publish step on it the same way as lint.
B4nan
force-pushed
the
chore/migrate-to-oxfmt
branch
from
5285134 to
c1362bc
Compare
github-actions
Bot
added
the
t-tooling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces ad-hoc formatting with oxfmt, matching the toolchain in apify-storage-local-js, apify-core, apify-web, and crawlee v4.
Stacked on top of #623 (eslint→oxlint migration). Will be retargeted to
masterafter the chain merges.Commits
chore: add oxfmt tooling— adds oxfmt 0.46.0 devDep,.oxfmtrc.json(4-space tabs, single quotes, 120 col),format/format:checkscripts, and wiresoxfmt --writeinto lint-stagedchore: apply oxfmt formatting— pureoxfmt --writereformat across all 67 modified files; one directive move from a trailing// eslint-disable-lineto// eslint-disable-next-lineabove afor-inloop (oxfmt split the trailing comment which made it apply to the wrong line)ci: add format-check job— addsformat-checkjob totest_and_release.yamland gatespublishon itTest plan
pnpm lint— cleanpnpm format:check— cleanpnpm test— 459/459 passingpnpm build— all 15 packages builtFollow-up
Once this lands, add the reformat commit SHA to
.git-blame-ignore-revs.