Skip to content

Commit 354fa30

Browse files
chore: add lint configs and disable actions checking it for now (#62)
1 parent 42fe0ad commit 354fa30

6 files changed

Lines changed: 907 additions & 1729 deletions

File tree

.github/workflows/_check_code.yaml

Lines changed: 26 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -17,31 +17,33 @@ jobs:
1717
- name: Run actionlint
1818
uses: rhysd/actionlint@v1.7.11
1919

20-
spell_check:
21-
name: Spell check
22-
runs-on: ubuntu-latest
23-
steps:
24-
- name: Checkout repository
25-
uses: actions/checkout@v6
26-
- name: Check spelling with typos
27-
uses: crate-ci/typos@v1
20+
# TODO: Fix spell check after we merge current PRs
21+
# spell_check:
22+
# name: Spell check
23+
# runs-on: ubuntu-latest
24+
# steps:
25+
# - name: Checkout repository
26+
# uses: actions/checkout@v6
27+
# - name: Check spelling with typos
28+
# uses: crate-ci/typos@v1
2829

29-
lint_check:
30-
name: Lint check
31-
runs-on: ubuntu-latest
32-
steps:
33-
- name: Checkout repository
34-
uses: actions/checkout@v6
35-
- name: Use Node.js
36-
uses: actions/setup-node@v6
37-
with:
38-
node-version: 24
39-
cache: 'npm'
40-
cache-dependency-path: 'package-lock.json'
41-
- name: Install dependencies
42-
run: npm ci
43-
- name: Lint
44-
run: npm run lint
30+
# TODO: Fix lint after we merge current PRs
31+
# lint_check:
32+
# name: Lint check
33+
# runs-on: ubuntu-latest
34+
# steps:
35+
# - name: Checkout repository
36+
# uses: actions/checkout@v6
37+
# - name: Use Node.js
38+
# uses: actions/setup-node@v6
39+
# with:
40+
# node-version: 24
41+
# cache: 'npm'
42+
# cache-dependency-path: 'package-lock.json'
43+
# - name: Install dependencies
44+
# run: npm ci
45+
# - name: Lint
46+
# run: npm run lint
4547

4648
type_check:
4749
name: Type check

eslint.config.mjs

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
import prettier from 'eslint-config-prettier';
2+
3+
import apify from '@apify/eslint-config/ts.js';
4+
import globals from 'globals';
5+
import tsEslint from 'typescript-eslint';
6+
7+
// eslint-disable-next-line import/no-default-export
8+
export default [
9+
{ ignores: ['**/dist', 'eslint.config.mjs'] },
10+
...apify,
11+
prettier,
12+
{
13+
languageOptions: {
14+
parser: tsEslint.parser,
15+
parserOptions: {
16+
project: 'tsconfig.json',
17+
},
18+
globals: {
19+
...globals.node,
20+
...globals.jest,
21+
},
22+
},
23+
plugins: {
24+
'@typescript-eslint': tsEslint.plugin,
25+
},
26+
rules: {
27+
'no-console': 0,
28+
},
29+
},
30+
];

lib/lib.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,6 @@ const createStandbyTask = async (actorNameOrId: string, buildNumber?: string): P
191191
throw new Error(`Actor "${actorNameOrId} doesn't contain actorStandby options`);
192192
}
193193
const { isEnabled, ...defaultActorStandby } = actorInfo.actorStandby;
194-
// @ts-expect-error This is not typed properly in ApifyClient, we need to remove it or API fails
195194
delete defaultActorStandby.disableStandbyFieldsOverride
196195

197196
const build = buildNumber ?? defaultActorStandby.build;

0 commit comments

Comments
 (0)