feat(bin): don't test on nonfunctional changes in json files#56
Merged
Conversation
metalwarrior665
requested review from
Patai5 and
oklinov
and removed request for
Patai5 and
oklinov
Member
Author
|
Thanks for the review. I will wait for @oklinov since he will return shortly. I also want to do unify the naming of changes a bit, I'm thinking 3 types:
|
Contributor
|
Feels much more cleaner after the last commit. Please just change the import in |
oklinov
requested changes
Mar 24, 2026
Member
Author
|
I refactored hopefully to simplify things. It seems to be working based on this action but it is hard to test because base commit doesn't work. Next steps:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was mostly vibecoded :)
resolves #54