fix(bin): in --base-commit, allow both sha string and Commit object#70
Merged
Conversation
ruocco-l
approved these changes
Mar 26, 2026
Contributor
ruocco-l
left a comment
ruocco-l
left a comment
There was a problem hiding this comment.
Looks ok, just a question on edgecase
| * @returns The SHA string if valid, otherwise throws an error. | ||
| */ | ||
| export const parseBaseCommit = (shaOrCommit: string | undefined): string | undefined => { | ||
| if (!shaOrCommit) return undefined; |
Contributor
There was a problem hiding this comment.
Shouldn't we throw an error here?
Member
Author
There was a problem hiding this comment.
I think we can keep it optional. Now the first commit in PR gets empty string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #67
Release new package version and after that merge this: apify-store/github-actions-source#24