refactor(build): make it obvious what files are actually ignored#81
Merged
refactor(build): make it obvious what files are actually ignored#81
Conversation
halvko
force-pushed
the
logs/obvious-file-ignores
branch
from
8a226a2 to
16c87f3
Compare
halvko
changed the title
Member
|
I will manually release this and hope it doesn't break stuff :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got these logs in CI:
Details
``` Last validated (base) commit to be used for build & test: Actors in repo: apify/facebook-ads-scraper, apify/facebook-comments-scraper, apify/facebook-followers-following-scraper, apify/facebook-games-scraper, apify/facebook-groups-scraper, apify/facebook-likes-scraper, apify/facebook-marketplace-scraper, apify/facebook-page-contact-information, apify/facebook-pages-scraper, apify/facebook-photos-scraper, apify/facebook-posts-scraper, apify/facebook-reels-scraper, apify/facebook-reviews-scraper, apify/facebook-search-scraper, apify/facebook-url-to-id, apify/facebook-video-search-scraper, apify/meta-brand-collaboration-scraper Standalone actors in repo: apify/facebook-events-scraper, apify/facebook-hashtag-scraper git log --merges --pretty=format:%H origin/master..origin/feat/meta-brand-collaboration-input-examples git log --pretty=format:'%H»¦«%aN<%aE>»¦«%aD»¦«' origin/master..origin/feat/meta-brand-collaboration-input-examples Base commit undefined not found in the commit range, returning all 1 commits Commits being returned: f26568391a05bee819dc453e258c3b29e07da187 git diff --name-only f26568391a05bee819dc453e258c3b29e07da187~..f26568391a05bee819dc453e258c3b29e07da187 Changed files (up to 50): actors/apify_meta-brand-collaboration-scraper/.actor/INPUT_SCHEMA.json git show f26568391a05bee819dc453e258c3b29e07da187~:actors/apify_meta-brand-collaboration-scraper/.actor/INPUT_SCHEMA.json git show f26568391a05bee819dc453e258c3b29e07da187:actors/apify_meta-brand-collaboration-scraper/.actor/INPUT_SCHEMA.json git show f26568391a05bee819dc453e258c3b29e07da187~:actors/apify_meta-brand-collaboration-scraper/.actor/INPUT_SCHEMA.json git show f26568391a05bee819dc453e258c3b29e07da187:actors/apify_meta-brand-collaboration-scraper/.actor/INPUT_SCHEMA.json [DIFF]: Ignored files (don't trigger test or build): git show f26568391a05bee819dc453e258c3b29e07da187~:actors/apify_meta-brand-collaboration-scraper/.actor/INPUT_SCHEMA.json git show f26568391a05bee819dc453e258c3b29e07da187:actors/apify_meta-brand-collaboration-scraper/.actor/INPUT_SCHEMA.json [DIFF]: Cosmetic files (should only trigger release build): actors/apify_meta-brand-collaboration-scraper/.actor/INPUT_SCHEMA.json git show f26568391a05bee819dc453e258c3b29e07da187~:actors/apify_meta-brand-collaboration-scraper/.actor/INPUT_SCHEMA.json git show f26568391a05bee819dc453e258c3b29e07da187:actors/apify_meta-brand-collaboration-scraper/.actor/INPUT_SCHEMA.json [DIFF]: Functional files (trigger test & release build): [DIFF]: No relevant files changed, skipping builds and tests git remote get-url origin ========================================= STARTED BUILDS: ========================================= FINISHED BUILDS: ========================================= SUMMARY: ========================================= actor_builds=[] ```Suggesting that changes to an
INPUT_SCHEMA.jsonnever force rebuild - I tested it and found out it at least sometimes does, and then looking into the library to confirm that it consistently works. For other to not go into the same rabbit hole I think it makes sense to make these log changes.