Skip to content

Commit 332673c

Browse files
authored
fix: Correct return type of storage get_info methods (#200)
1 parent 1a76124 commit 332673c

3 files changed

Lines changed: 9 additions & 13 deletions

File tree

src/crawlee/storages/dataset.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -232,11 +232,7 @@ async def export_to(self, **kwargs: Unpack[ExportToKwargs]) -> None:
232232
raise ValueError(f'Unsupported content type: {content_type}')
233233

234234
async def get_info(self) -> DatasetMetadata | None:
235-
"""Get an object containing general information about the dataset.
236-
237-
Returns:
238-
Object returned by calling the GET dataset API endpoint.
239-
"""
235+
"""Get an object containing general information about the dataset."""
240236
metadata = await self._resource_client.get()
241237
if isinstance(metadata, DatasetMetadata):
242238
return metadata

src/crawlee/storages/key_value_store.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
from typing_extensions import override
66

7-
from crawlee.models import KeyValueStoreKeyInfo
7+
from crawlee.models import KeyValueStoreKeyInfo, KeyValueStoreMetadata
88
from crawlee.storages.base_storage import BaseStorage
99

1010
if TYPE_CHECKING:
@@ -59,6 +59,10 @@ def id(self) -> str:
5959
def name(self) -> str | None:
6060
return self._name
6161

62+
async def get_info(self) -> KeyValueStoreMetadata | None:
63+
"""Get an object containing general information about the key value store."""
64+
return await self._resource_client.get()
65+
6266
@override
6367
@classmethod
6468
async def open(

src/crawlee/storages/request_queue.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
ProcessedRequest,
1919
Request,
2020
RequestQueueHeadState,
21+
RequestQueueMetadata,
2122
)
2223
from crawlee.storages.base_storage import BaseStorage
2324
from crawlee.storages.request_provider import RequestProvider
@@ -27,7 +28,6 @@
2728

2829
from crawlee.base_storage_client import BaseStorageClient
2930
from crawlee.configuration import Configuration
30-
from crawlee.models import BaseStorageMetadata
3131

3232
logger = getLogger(__name__)
3333

@@ -458,12 +458,8 @@ async def is_finished(self) -> bool:
458458
is_head_consistent = await self.ensure_head_is_non_empty(ensure_consistency=True)
459459
return is_head_consistent and len(self._queue_head_dict) == 0 and self._in_progress_count() == 0
460460

461-
async def get_info(self) -> BaseStorageMetadata | None:
462-
"""Get an object containing general information about the request queue.
463-
464-
Returns:
465-
Object returned by calling the GET request queue API endpoint.
466-
"""
461+
async def get_info(self) -> RequestQueueMetadata | None:
462+
"""Get an object containing general information about the request queue."""
467463
return await self._resource_client.get()
468464

469465
@override

0 commit comments

Comments
 (0)