Skip to content

Commit 42a89ef

Browse files
committed
Review comments
1 parent 5820e07 commit 42a89ef

6 files changed

Lines changed: 12 additions & 7 deletions

File tree

src/crawlee/browsers/_playwright_browser_plugin.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,12 +90,11 @@ def __init__(
9090
# Chromium parameter 'channel' set to 'chrome' enables using installed Google Chrome.
9191
default_launch_browser_options['channel'] = 'chrome'
9292

93-
if explicit_browser_launch_options.get(
93+
if executable_path := explicit_browser_launch_options.get(
9494
'executable_path', default_launch_browser_options.get('executable_path')
9595
):
9696
logger.debug(
97-
f'Using browser executable from {default_launch_browser_options["executable_path"]},'
98-
f" which takes precedence over 'chrome' channel."
97+
f"Using browser executable from {executable_path}, which takes precedence over 'chrome' channel."
9998
)
10099

101100
self._browser_type: BrowserType = browser_type

src/crawlee/project_template/templates/main_playwright_chrome.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,6 @@
1010
headless=True,
1111
max_requests_per_crawl=10,
1212
browser_type="chrome",
13-
{{ self.http_client_instantiation() }})
13+
{{ self.http_client_instantiation() }}
14+
)
1415
# % endblock

src/crawlee/project_template/templates/main_playwright_firefox.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,6 @@
1010
headless=True,
1111
max_requests_per_crawl=10,
1212
browser_type="firefox",
13-
{{ self.http_client_instantiation() }})
13+
{{ self.http_client_instantiation() }}
14+
)
1415
# % endblock

src/crawlee/project_template/templates/main_playwright_webkit.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,6 @@
1010
headless=True,
1111
max_requests_per_crawl=10,
1212
browser_type="webkit",
13-
{{ self.http_client_instantiation() }})
13+
{{ self.http_client_instantiation() }}
14+
)
1415
# % endblock

src/crawlee/project_template/templates/routes_camoufox.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from crawlee.crawlers import PlaywrightCrawlingContext
1+
rom crawlee.crawlers import PlaywrightCrawlingContext
22
from crawlee.router import Router
33

44
router = Router[PlaywrightCrawlingContext]()

tests/e2e/conftest.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ def pytest_configure(config: Config) -> None:
1515
'impit',
1616
'playwright',
1717
'playwright_camoufox',
18+
'playwright_chrome',
19+
'playwright_firefox',
20+
'playwright_webkit',
1821
'parsel',
1922
'beautifulsoup',
2023
'uv',

0 commit comments

Comments
 (0)