Skip to content

Commit 44b6eee

Browse files
vdusekclaude
andcommitted
test: increase browser pool operation timeout for Firefox on Windows CI
The default 15s operation_timeout is not enough for Firefox's launch_persistent_context on busy Windows CI runners. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 326ffbe commit 44b6eee

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

tests/unit/browsers/test_browser_pool.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
from __future__ import annotations
22

3+
from datetime import timedelta
34
from typing import TYPE_CHECKING
45
from unittest.mock import AsyncMock
56

@@ -103,7 +104,10 @@ async def test_new_page_with_each_plugin(server_url: URL) -> None:
103104

104105
@run_alone_on_mac
105106
async def test_with_default_plugin_constructor(server_url: URL) -> None:
106-
async with BrowserPool.with_default_plugin(headless=True, browser_type='firefox') as browser_pool:
107+
# Use a generous operation timeout so that Firefox has enough time to launch on slow Windows CI.
108+
async with BrowserPool.with_default_plugin(
109+
headless=True, browser_type='firefox', operation_timeout=timedelta(seconds=60)
110+
) as browser_pool:
107111
assert len(browser_pool.plugins) == 1
108112
assert isinstance(browser_pool.plugins[0], PlaywrightBrowserPlugin)
109113

0 commit comments

Comments
 (0)