Skip to content

Commit 72f8451

Browse files
committed
Add debug to autoscaled pool. Is the problem there?
1 parent 55eb4cb commit 72f8451

3 files changed

Lines changed: 10 additions & 5 deletions

File tree

src/crawlee/_autoscaling/autoscaled_pool.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,9 @@ async def run(self) -> None:
124124

125125
try:
126126
await run.result
127+
logger.info('Finished naturally')
127128
except AbortError:
129+
logger.info('AbortError')
128130
orchestrator.cancel()
129131
for task in run.worker_tasks:
130132
if not task.done():
@@ -245,16 +247,16 @@ async def _worker_task_orchestrator(self, run: _AutoscaledPoolRun) -> None:
245247
await asyncio.wait_for(run.worker_tasks_updated.wait(), timeout=0.5)
246248
finally:
247249
if finished:
248-
logger.debug('`is_finished_function` reports that we are finished')
250+
logger.info('`is_finished_function` reports that we are finished')
249251
elif run.result.done() and run.result.exception() is not None:
250-
logger.debug('Unhandled exception in `run_task_function`')
252+
logger.info('Unhandled exception in `run_task_function`')
251253

252254
if run.worker_tasks:
253-
logger.debug('Terminating - waiting for tasks to complete')
255+
logger.info('Terminating - waiting for tasks to complete')
254256
await asyncio.wait(run.worker_tasks, return_when=asyncio.ALL_COMPLETED)
255-
logger.debug('Worker tasks finished')
257+
logger.info('Worker tasks finished')
256258
else:
257-
logger.debug('Terminating - no running tasks to wait for')
259+
logger.info('Terminating - no running tasks to wait for')
258260

259261
if not run.result.done():
260262
run.result.set_result(object())

src/crawlee/crawlers/_basic/_basic_crawler.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1347,6 +1347,7 @@ async def __is_finished_function(self) -> bool:
13471347

13481348
if self._abort_on_error and self._failed:
13491349
self._failed = False
1350+
self.log.info('_abort_on_error')
13501351
return True
13511352

13521353
if self._keep_alive:

tests/unit/crawlers/_basic/test_basic_crawler.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1301,6 +1301,8 @@ async def test_timeout_in_handler(sleep_type: str) -> None:
13011301
)
13021302
crawler.log.setLevel(logging.DEBUG)
13031303
logging.getLogger('crawlee.storage_clients._file_system._request_queue_client').setLevel(logging.DEBUG)
1304+
logging.getLogger('crawlee._autoscaling.autoscaled_pool').setLevel(logging.INFO)
1305+
13041306

13051307
mocked_handler_before_sleep = Mock()
13061308
mocked_handler_after_sleep = Mock()

0 commit comments

Comments
 (0)