Skip to content

Commit 7dd61b9

Browse files
authored
chore: Remove unused ID arg from BaseRequestData.from_url (#763)
- `BaseRequestData` does not have the `id` attribute. - It is not breaking, as - `from_url` accepts `**kwargs`, - and `BaseRequestData` is not exposed to the public.
1 parent 63c1db5 commit 7dd61b9

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

src/crawlee/_request.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,6 @@ def from_url(
187187
payload: HttpPayload | str | None = None,
188188
label: str | None = None,
189189
unique_key: str | None = None,
190-
id: str | None = None,
191190
keep_url_fragment: bool = False,
192191
use_extended_unique_key: bool = False,
193192
**kwargs: Any,
@@ -208,12 +207,9 @@ def from_url(
208207
use_extended_unique_key=use_extended_unique_key,
209208
)
210209

211-
id = id or unique_key_to_request_id(unique_key)
212-
213210
request = cls(
214211
url=url,
215212
unique_key=unique_key,
216-
id=id,
217213
method=method,
218214
headers=headers,
219215
payload=payload,

0 commit comments

Comments
 (0)