Commit b723b58
authored
ci: inline beta release jobs to fix PyPI trusted publishing (#1875)
## Summary
PyPI's Trusted Publishing rejects OIDC tokens issued from reusable
workflows:
> The claims in this token suggest that the calling workflow is a
reusable workflow. Reusable workflows are not currently supported by
PyPI's Trusted Publishing.
`on_master.yaml` was invoking `manual_release_beta.yaml` via `uses:`,
which made the OIDC token reflect a reusable workflow call. The same fix
was applied in `apify/apify-shared-python#63`.
## Changes
- `on_master.yaml`: inline the four beta release jobs
(`release_prepare`, `changelog_update`, `pypi_publish`,
`doc_release_post_publish`) directly, instead of calling
`manual_release_beta.yaml` as a reusable workflow.
- `manual_release_beta.yaml`: remove the `workflow_call` trigger (no
longer invoked from another workflow) and add a comment explaining why
the duplication exists.
- Drop the unused `tag_name` output from `release_prepare` in both
files.
## Follow-up
The PyPI Trusted Publisher for `crawlee` is currently configured for
`manual_release_beta.yaml`. After this is merged, an entry for
`on_master.yaml` needs to be added on PyPI so the automatic beta release
passes verification.
See:
https://docs.pypi.org/trusted-publishers/troubleshooting/#reusable-workflows-on-github1 parent 48891c5 commit b723b58
2 files changed
Lines changed: 63 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
5 | 9 | | |
6 | 10 | | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| |||
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
19 | | - | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
49 | 52 | | |
50 | 53 | | |
51 | 54 | | |
52 | 55 | | |
53 | 56 | | |
54 | 57 | | |
55 | 58 | | |
56 | | - | |
| 59 | + | |
57 | 60 | | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
58 | 110 | | |
59 | 111 | | |
60 | | - | |
61 | 112 | | |
62 | | - | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
63 | 118 | | |
0 commit comments