Skip to content

Commit daf91a9

Browse files
authored
ci: Grant checks: read to doc release job in on_master (#1914)
## Summary After merging #1913, `on_master.yaml` started failing with: > The nested job 'release_docs' is requesting 'checks: read', but is only allowed 'checks: none'. When a workflow is called via `uses:`, the caller's `permissions:` block must explicitly include every permission the called workflow requests. The `doc_release` job in `on_master.yaml` was missing `checks: read`, which `manual_release_docs.yaml` requests for its wait-for-checks step. Also pins the wait-for-checks action in `manual_release_docs.yaml` to `apify/actions/wait-for-checks@v1.2.0` (the file slipped through the original PR — the other three release workflows already use the tagged version).
1 parent 58d7881 commit daf91a9

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

.github/workflows/manual_release_docs.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ jobs:
2828

2929
steps:
3030
# Gate manual dispatches on the `Checks` workflow already succeeding on this commit (run by `on_master.yaml`);
31-
# skipped when called from another workflow. TODO: pin to a tag after apify/workflows#238 is merged.
31+
# skipped when called from another workflow.
3232
- name: Wait for checks
3333
if: github.event_name == 'workflow_dispatch'
34-
uses: apify/workflows/wait-for-checks@wait-for-checks-action
34+
uses: apify/actions/wait-for-checks@v1.2.0
3535
with:
3636
ref: ${{ github.sha }}
3737
check-regexp: '^Checks'

.github/workflows/on_master.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ jobs:
2828
contents: write
2929
pages: write
3030
id-token: write
31+
checks: read
3132
uses: ./.github/workflows/manual_release_docs.yaml
3233
secrets: inherit
3334

0 commit comments

Comments
 (0)