Commit fa58438
authored
fix: Fix
### Description
- Remove unintentional side-effect: When a custom configuration was
passed to the `PlaywrightCrawler`, it tried to set it in the global
`service_locator`
### Testing
- Updated unit test
### Checklist
- [ ] CI passedPlaywrightCrawler unintentionally setting the global configuration (#1747)1 parent ea4fa01 commit fa58438
2 files changed
Lines changed: 7 additions & 9 deletions
File tree
- src/crawlee/crawlers/_playwright
- tests/unit/crawlers/_playwright
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
16 | 15 | | |
17 | 16 | | |
18 | 17 | | |
| |||
145 | 144 | | |
146 | 145 | | |
147 | 146 | | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | 147 | | |
153 | 148 | | |
154 | 149 | | |
| |||
Lines changed: 7 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
791 | 791 | | |
792 | 792 | | |
793 | 793 | | |
794 | | - | |
| 794 | + | |
795 | 795 | | |
| 796 | + | |
796 | 797 | | |
797 | | - | |
798 | | - | |
799 | | - | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
800 | 803 | | |
801 | 804 | | |
802 | 805 | | |
| |||
0 commit comments