chore: Allow opening pre-existing unnamed storage#1414
Merged
Conversation
github-actions
Bot
added
t-tooling
Pijukatel
removed
the
tested
github-actions
Bot
added
the
tested
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR allows opening pre-existing unnamed storage instances by their ID, removing the previous restriction that required either a name or alias. The change enables users to reconnect to storage instances that were created with aliases but need to be accessed later using only their ID.
- Removed the runtime error that required storage instances to have either a name or an alias
- Modified caching logic to handle unnamed storage instances more gracefully
- Added test coverage for opening pre-existing unnamed storage by ID
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/crawlee/storages/_storage_instance_manager.py | Removed the RuntimeError for unnamed storage and restructured caching logic with clearer comments |
| tests/unit/storages/test_storage_instance_manager.py | Added test case to verify pre-existing unnamed storage can be opened by ID |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues
Testing