Skip to content

fix(playwright): dispose of APIResponse body for send_request #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 2 commits into from
Mar 2, 2026
Merged

fix(playwright): dispose of APIResponse body for send_request #1771

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca060c9
fix(playwright): dispose of APIResponse body
kozlice Mar 1, 2026
5ad4de6
fix: optimize imports
kozlice Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/crawlee/crawlers/_playwright/_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,14 @@
from dataclasses import dataclass
from typing import TYPE_CHECKING, Literal, Protocol, TypedDict

from playwright.async_api import APIResponse, Response
Comment thread
kozlice marked this conversation as resolved.
Outdated

from crawlee import HttpHeaders
from crawlee._utils.docs import docs_group

if TYPE_CHECKING:
from collections.abc import AsyncGenerator

from playwright.async_api import APIResponse, Response
from typing_extensions import NotRequired, Self


Expand Down Expand Up @@ -56,6 +57,9 @@ async def from_playwright_response(cls, response: Response | APIResponse, protoc
# Used http protocol version cannot be obtained from `Response` and has to be passed as additional argument.
http_version = protocol
_content = await response.body()
# If not called then the body will stay in memory until the context closes.
if isinstance(response, APIResponse):
await response.dispose()

return cls(http_version=http_version, status_code=status_code, headers=headers, _content=_content)

Expand Down
Loading