Skip to content

test: Increase sleep tolerance in request_max_duration test for Windows CI #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 1 commit into from
Mar 31, 2026
+5 −4
Merged

test: Increase sleep tolerance in request_max_duration test for Windows CI #1827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tests/unit/_statistics/test_request_max_duration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,10 @@
async def test_request_max_duration_tracks_maximum() -> None:
"""Test that request_max_duration correctly tracks the maximum duration, not the minimum."""

# asyncio.sleep() can sleep slightly shorter than expected https://bugs.python.org/issue31539#msg302699
asyncio_sleep_time_tolerance = 0.015
sleep_time = 0.05
# asyncio.sleep() can sleep significantly shorter than expected on Windows due to poor timer resolution
# https://bugs.python.org/issue31539#msg302699
asyncio_sleep_time_tolerance = 0.05
sleep_time = 0.2

async with Statistics.with_default_state() as statistics:
# Record a short request
Expand All @@ -20,7 +21,7 @@ async def test_request_max_duration_tracks_maximum() -> None:

# Record a longer request
statistics.record_request_processing_start('request_2')
await asyncio.sleep(sleep_time) # 50ms delay
await asyncio.sleep(sleep_time) # 200ms delay
statistics.record_request_processing_finish('request_2')
second_duration = statistics.state.request_max_duration

Expand Down
Loading