Skip to content

test: Fix flaky event manager tests by replacing sleep with wait #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 1 commit into from
Apr 2, 2026
+5 −5
Merged

test: Fix flaky event manager tests by replacing sleep with wait #1830

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/unit/events/test_event_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ async def test_emit_invokes_registered_sync_listener(
event_manager.on(event=Event.SYSTEM_INFO, listener=sync_listener)
event_manager.emit(event=Event.SYSTEM_INFO, event_data=event_system_info_data)

await asyncio.sleep(0.1) # Allow some time for the event to be processed
await event_manager.wait_for_all_listeners_to_complete()

assert sync_listener.call_count == 1
assert sync_listener.call_args[0] == (event_system_info_data,)
Expand All @@ -71,7 +71,7 @@ async def test_emit_invokes_both_sync_and_async_listeners(
event_manager.on(event=Event.SYSTEM_INFO, listener=async_listener)
event_manager.emit(event=Event.SYSTEM_INFO, event_data=event_system_info_data)

await asyncio.sleep(0.1) # Allow some time for the event to be processed
await event_manager.wait_for_all_listeners_to_complete()

assert async_listener.call_count == 1
assert async_listener.call_args[0] == (event_system_info_data,)
Expand All @@ -90,7 +90,7 @@ async def test_emit_event_with_no_listeners(

# Attempt to emit an event for which no listeners are registered, it should not fail
event_manager.emit(event=Event.SYSTEM_INFO, event_data=event_system_info_data)
await asyncio.sleep(0.1) # Allow some time for the event to be processed
await event_manager.wait_for_all_listeners_to_complete()

# Ensure the listener for the other event was not called
assert async_listener.call_count == 0
Expand All @@ -114,7 +114,7 @@ async def async_listener() -> None:
event_manager.on(event=Event.SYSTEM_INFO, listener=async_listener)

event_manager.emit(event=Event.SYSTEM_INFO, event_data=event_system_info_data)
await asyncio.sleep(0.1) # Allow some time for the event to be processed
await event_manager.wait_for_all_listeners_to_complete()

assert sync_mock.call_count == 1
assert async_mock.call_count == 1
Expand All @@ -139,7 +139,7 @@ async def test_removed_listener_not_invoked_on_emit(
event_manager.off(event=Event.SYSTEM_INFO, listener=async_listener)
event_manager.emit(event=Event.SYSTEM_INFO, event_data=event_system_info_data)

await asyncio.sleep(0.1) # Allow some time for the event to be processed
await event_manager.wait_for_all_listeners_to_complete()
assert async_listener.call_count == 0


Expand Down
Loading