fix: Fix _is_empty_cache invalidation in FileSystemRequestQueueClient#1840
Closed
fix: Fix _is_empty_cache invalidation in FileSystemRequestQueueClient#1840
_is_empty_cache invalidation in FileSystemRequestQueueClient#1840Conversation
…RequestQueueClient` Ensure all state-mutating operations properly invalidate the `_is_empty_cache` to prevent stale values that could cause the crawler to shut down prematurely. - Add cache invalidation to `fetch_next_request` (only when a request is found) - Remove redundant early invalidation in `add_batch_of_requests` - Fix cache/return mismatch in `is_empty` fast path - Add tests for cache correctness through lifecycle and concurrent operations Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1840 +/- ##
==========================================
- Coverage 92.27% 92.25% -0.02%
==========================================
Files 157 157
Lines 10909 10909
==========================================
- Hits 10066 10064 -2
- Misses 843 845 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_is_empty_cacherace condition inFileSystemRequestQueueClientwherefetch_next_requestwas the only state-mutating method that didn't invalidate the cache, potentially causing staleis_empty()resultsfetch_next_request(conditionally, only when a request is actually found, to avoid hot-path waste)add_batch_of_requestsis_emptyfast path where_is_empty_cachewas set toTruebut return value could theoretically differ🤖 Generated with Claude Code