Skip to content

test: Fix storage_client fixture cleanup#1841

Merged
janbuchar merged 1 commit intomasterfrom
fix-storage-client-cleanup
Apr 8, 2026
Merged

test: Fix storage_client fixture cleanup#1841
janbuchar merged 1 commit intomasterfrom
fix-storage-client-cleanup

Conversation

@janbuchar
Copy link
Copy Markdown
Collaborator

  • fixes a bunch of random "Event loop is closed" warnings in tests

@janbuchar janbuchar added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Apr 8, 2026
@janbuchar janbuchar requested a review from vdusek April 8, 2026 10:18
@janbuchar janbuchar added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Apr 8, 2026
@github-actions github-actions bot added this to the 138th sprint - Tooling team milestone Apr 8, 2026
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Apr 8, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.24%. Comparing base (8b53e27) to head (564e07f).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1841      +/-   ##
==========================================
- Coverage   92.27%   92.24%   -0.03%     
==========================================
  Files         157      157              
  Lines       10909    10909              
==========================================
- Hits        10066    10063       -3     
- Misses        843      846       +3     
Flag Coverage Δ
unit 92.24% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks

@janbuchar janbuchar merged commit 415a0ce into master Apr 8, 2026
32 checks passed
@janbuchar janbuchar deleted the fix-storage-client-cleanup branch April 8, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants