Skip to content

test: Fix flaky tests in adaptive crawler and sitemap loader #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 1 commit into from
Apr 15, 2026
Merged

test: Fix flaky tests in adaptive crawler and sitemap loader #1847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/unit/crawlers/_adaptive_playwright/test_adaptive_playwright_crawler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,6 +631,10 @@ async def request_handler(context: AdaptivePlaywrightCrawlingContext) -> None:
mocked_browser_handler.assert_called_once_with()


@pytest.mark.flaky(
rerun=3,
reason='Test is flaky on Windows and MacOS, see https://github.com/apify/crawlee-python/issues/1650.',
)
async def test_adaptive_context_query_selector_beautiful_soup(test_urls: list[str]) -> None:
"""Test that `context.query_selector_one` works regardless of the crawl type for BeautifulSoup variant.
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/request_loaders/test_sitemap_request_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ async def wait_for_sitemap_loader_not_empty(sitemap_loader: SitemapRequestLoader
sitemap_loader = SitemapRequestLoader([str(sitemap_url)], http_client=http_client, persist_state_key=persist_key)

# Give time to load
await asyncio.wait_for(wait_for_sitemap_loader_not_empty(sitemap_loader), timeout=2)
await asyncio.wait_for(wait_for_sitemap_loader_not_empty(sitemap_loader), timeout=10)

await sitemap_loader.close()

Expand Down
Loading