Skip to content

fix: Gracefully close sitemap stream on SitemapRequestLoader abort #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pijukatel merged 2 commits into from
Jun 22, 2026
Merged

fix: Gracefully close sitemap stream on SitemapRequestLoader abort #1979

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa4ccc4
gracefully close sitemap stream on `SitemapRequestLoader` abort
Mantisus Jun 18, 2026
ae6c069
use `contextlib.aclosing`
Mantisus Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/crawlee/request_loaders/_sitemap_request_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,8 @@ async def abort_loading(self) -> None:
self._loading_task.cancel()
with suppress(asyncio.CancelledError):
await self._loading_task
# Let the streaming request shut down gracefully.
await asyncio.sleep(0)

async def close(self) -> None:
"""Close the request loader."""
Expand Down
Loading