Skip to content

v4: tough-cookie's CookieJars throw on invalid Set-Cookie response contents #3425

@barjin

Description

@barjin

As seen in apify/actor-scraper#236, the internal CookieJar can throw on a deformed Set-Cookie response from the server.

This error is now not caught anywhere and will kill the entire script if used, e.g., from a helper function (like discoverValidSitemaps).

We should treat all CookieJar methods as potentially throwing and only print warnings on thrown errors.

Metadata

Metadata

Assignees

Labels

t-toolingIssues with this label are in the ownership of the tooling team.

Type

No type
No fields configured for issues without a type.

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions