Skip to content

feat: Parallel sitemap discovery#3571

Open
baptistejamin wants to merge 2 commits intoapify:masterfrom
baptistejamin:feat/batch-sitemap
Open

feat: Parallel sitemap discovery#3571
baptistejamin wants to merge 2 commits intoapify:masterfrom
baptistejamin:feat/batch-sitemap

Conversation

@baptistejamin
Copy link
Copy Markdown

Hey there!

Right now, nested sitemap discovery is sequential.

It can be quite slow for large sitemaps and slow remote servers.

This PR introduces a batching mechanism (the same one as the core) and a new concurrency (default) 1 allowing to batch sitemaps in //

I did the code with the help of Cursor / Opus 4.5, and my own inputs.

Do whatever you want with it :)

I can help to change the design if needed.

@baptistejamin baptistejamin changed the title Parallel sitemap discovery feat: Parallel sitemap discovery Apr 15, 2026
@janbuchar janbuchar requested review from barjin and janbuchar April 16, 2026 18:10
Copy link
Copy Markdown
Member

@barjin barjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

A few thoughts inline, mostly around the option name and a couple of subtle behavioural changes (unbounded inProgressEntries growth) that would benefit from either a tweak or at least a note in the docs/changelog.

Comment thread packages/core/src/storages/sitemap_request_list.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants