feat: add |skipScreenFingerprint| option to handle missing screen properties#480
Open
jagadeshjai wants to merge 1 commit into
Open
feat: add |skipScreenFingerprint| option to handle missing screen properties#480jagadeshjai wants to merge 1 commit into
jagadeshjai wants to merge 1 commit into
Conversation
jagadeshjai
force-pushed
the
jagadesh/feat__skip_screen_fingerprint
branch
from
3894475 to
9c306b5
Compare
…perties Add a new `skipScreenFingerprint` option to FingerprintGeneratorOptions that allows users to generate fingerprints without requiring screen properties. This eliminates the need for silent retries when screen generation fails. - Added `skipScreenFingerprint` boolean option to FingerprintGeneratorOptions - Updated Fingerprint type to allow screen property to be null (ScreenFingerprint | null) - Replace workaround `if (!fingerprint.screen) continue` with explicit user-controlled behavior Benefit: - Improves reliability by avoiding unnecessary generation retries and better performance when screen properties are not needed Closes: apify#479
jagadeshjai
force-pushed
the
jagadesh/feat__skip_screen_fingerprint
branch
from
9c306b5 to
38a7fa3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new
skipScreenFingerprintoption to FingerprintGeneratorOptions that allows users to generate fingerprints without requiring screen properties. This eliminates the need for silent retries when screen generation fails.skipScreenFingerprintboolean option to FingerprintGeneratorOptionsif (!fingerprint.screen) continuewith explicit user-controlled behaviorBenefit:
Closes: #479