Skip to content

fix: reject zero viewport training records#543

Closed
alan747271363-art wants to merge 1 commit into
apify:masterfrom
alan747271363-art:codex/fingerprint-zero-screen-schema
Closed

fix: reject zero viewport training records#543
alan747271363-art wants to merge 1 commit into
apify:masterfrom
alan747271363-art:codex/fingerprint-zero-screen-schema

Conversation

@alan747271363-art
Copy link
Copy Markdown

@alan747271363-art alan747271363-art commented May 14, 2026

Summary

  • tighten the generator-network record schema so innerWidth, innerHeight, clientWidth, and clientHeight must be positive
  • add focused schema tests covering zero-value rejection and positive-value acceptance

Context

This follows the review feedback on #540: rejecting invalid screen dimensions in the training record schema prevents zero viewport values from entering the model in the first place, instead of normalizing generated fingerprints at runtime.

@algora-pbc /claim #6

@barjin
Copy link
Copy Markdown
Member

barjin commented May 19, 2026

Closing in favour of #544

@barjin barjin closed this May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants