Skip to content

Commit c0c1014

Browse files
authored
fix: switch packageManager devEngines to warn + add minimumReleaseAge (#286)
Two related supply-chain hygiene changes: **1. `devEngines.packageManager.onFail: error → warn`** pnpm v10 still shells out to system npm for several subcommands (`pnpm version`, `pnpm config`, etc.). This repo also has direct npm invocations in CI: - \`.github/workflows/tests.yaml:137\` — `npm install` - \`.github/workflows/sync_branches.yaml:39\` — `npm i @octokit/rest@release-19.x` - \`.github/workflows/claude-md-maintenance.yml:31\` — `npm install -g @anthropic-ai/claude-code` With `onFail: error` those trip `EBADDEVENGINES`. `warn` keeps the dev-visible signal without blocking. Also pins the version to `10.33.0` for clarity. **2. Add `minimumReleaseAge: 1440` to `pnpm-workspace.yaml`** 24-hour quarantine on new package versions. Mitigates compromised npm packages that get discovered and yanked within the first day (shai-hulud worm, nx self-replicator, etc.). Brings this repo in line with the rest of the pnpm-migrated public repos. Mirrors the rollout in apify/apify-client-js#895 + #896.
1 parent ff1ff70 commit c0c1014

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,16 @@
1111
"typescript": "^6.0.2",
1212
"vitest": "^4.1.2"
1313
},
14-
"packageManager": "pnpm@10.33.0+sha512.10568bb4a6afb58c9eb3630da90cc9516417abebd3fabbe6739f0ae795728da1491e9db5a544c76ad8eb7570f5c4bb3d6c637b2cb41bfdcdb47fa823c8649319",
14+
"packageManager": "pnpm@10.33.4",
1515
"devEngines": {
1616
"runtime": {
1717
"name": "node",
1818
"onFail": "error"
1919
},
2020
"packageManager": {
2121
"name": "pnpm",
22-
"onFail": "error"
22+
"version": "10.33.4",
23+
"onFail": "warn"
2324
}
2425
}
2526
}

pnpm-workspace.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,7 @@
11
packages:
22
- execute-workflow
3+
4+
# Supply-chain protection: require packages to be at least 24h old before pnpm will install them.
5+
# Mitigates compromised npm packages discovered and yanked within the first day (shai-hulud worm,
6+
# nx self-replicator, etc.). 1440 minutes = 24 hours.
7+
minimumReleaseAge: 1440

0 commit comments

Comments
 (0)