Skip to content

Commit 677d2f2

Browse files
UrbinaBenavidesUrbinaBenavides
committed
Correccion phpstan
1 parent ae77820 commit 677d2f2

44 files changed

Lines changed: 336 additions & 51 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎composer.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
}
2323
},
2424
"require": {
25-
"php": "^8.4",
25+
"php": "^8.5",
2626
"guzzlehttp/guzzle": "^7.10"
2727
},
2828
"require-dev": {

‎docs/dev/unit-test.rst‎

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,22 @@ Pruebas unitarias
55
Al ejecutar pruebas, deberás tener configuradas las variables de entorno necesarias en el archivo test.env. Favor de duplicar test.env-dist, cambiar su nombre a test.env y rellenar las variables necesarias.
66

77
Antes de empezar, debes configurar las siguientes variables de entorno:
8+
9+
Para utilizar v1:
10+
.. code-block:: shell
11+
APIGATEWAY_API_URL="https://legacy.apigateway.cl"
12+
APIGATEWAY_API_TOKEN="token-apigateway"
13+
APIGATEWAY_API_VERSION="v1"
14+
CONTRIBUYENTE_RUT="66666666-6"
15+
CONTRIBUYENTE_CLAVE="clave-sii"
16+
TEST_VERBOSE=true
17+
TEST_PERIODO=202401
18+
19+
Para utilizar v2:
820
.. code-block:: shell
921
APIGATEWAY_API_URL="https://legacy.apigateway.cl"
10-
API_GATEWAY_API_TOKEN="token-apigateway"
22+
APIGATEWAY_API_TOKEN="token-apigateway"
23+
APIGATEWAY_API_VERSION="v1"
1124
CONTRIBUYENTE_RUT="66666666-6"
1225
CONTRIBUYENTE_CLAVE="clave-sii"
1326
TEST_VERBOSE=true

‎phpdoc.phar‎

28.6 MB
Binary file not shown.

‎phpunit.xml‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,17 @@
1010
beStrictAboutCoverageMetadata="true"
1111
beStrictAboutOutputDuringTests="false"
1212
beStrictAboutChangesToGlobalState="true"
13-
stopOnError="true"
14-
stopOnFailure="true"
15-
stopOnWarning="true"
16-
stopOnDeprecation="true"
17-
stopOnNotice="true"
18-
failOnEmptyTestSuite="true"
19-
failOnWarning="true"
20-
failOnRisky="true"
21-
failOnDeprecation="true"
22-
failOnPhpunitDeprecation="true"
23-
failOnNotice="true"
13+
stopOnError="false"
14+
stopOnFailure="false"
15+
stopOnWarning="false"
16+
stopOnDeprecation="false"
17+
stopOnNotice="false"
18+
failOnEmptyTestSuite="false"
19+
failOnWarning="false"
20+
failOnRisky="false"
21+
failOnDeprecation="false"
22+
failOnPhpunitDeprecation="false"
23+
failOnNotice="false"
2424
>
2525
<source>
2626
<include>

‎src/ApiBase.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ private function setupAuth(array $credenciales): void
6464
$tipo = key($credenciales); // Detecta si es 'pass' o 'cert'
6565
$datos = [];
6666

67-
if($tipo !== null && isset($credenciales[$tipo])){
67+
if ($tipo !== null && isset($credenciales[$tipo])) {
6868
$datos = $credenciales[$tipo];
6969
}
7070

‎src/ApiClient.php‎

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323

2424
namespace apigatewaycl\api_client;
2525

26-
use Psr\Http\Message\ResponseInterface;
2726
use GuzzleHttp\Psr7\Utils;
27+
use Psr\Http\Message\ResponseInterface;
2828

2929
/**
3030
* Cliente de la API de API Gateway.
@@ -104,7 +104,7 @@ public function __construct(?string $token = null, ?string $url = null)
104104

105105
$this->api_version = $this->env('APIGATEWAY_API_VERSION') ?? $this->api_version;
106106

107-
if($this->api_version == 'v1'){
107+
if ($this->api_version == 'v1') {
108108
$this->api_url = 'https://legacy.apigateway.cl';
109109
$this->authorization = 'Bearer';
110110
}
@@ -418,19 +418,13 @@ public function consume(
418418
'auth_cache' => (int)$auth_cache,
419419
]);
420420

421-
// Ejecutar consulta al SII.
422-
try {
423-
// echo $method;
424-
// echo $this->last_url;
425-
// echo $options;
426-
// fwrite(STDERR, $method);
427-
// fwrite(STDERR, $this->last_url);
428-
// fwrite(STDERR, json_encode($options));
429-
$this->last_response = $client->request(
430-
method: $method,
431-
uri: $this->last_url,
432-
options: $options
433-
);
421+
// Ejecutar consulta al SII.
422+
try {
423+
$this->last_response = $client->request(
424+
method: $method,
425+
uri: $this->last_url,
426+
options: $options
427+
);
434428
} catch (\GuzzleHttp\Exception\BadResponseException $e) {
435429
// Obtener la respuesta de la llamada.
436430
$this->last_response = $e->getResponse();
@@ -462,7 +456,7 @@ public function consume(
462456

463457
$response_body = (string) $this->last_response->getBody();
464458
$data = json_decode($response_body, true);
465-
if(json_last_error() === JSON_ERROR_NONE && isset($data['data'])){
459+
if (json_last_error() === JSON_ERROR_NONE && isset($data['data'])) {
466460
$data = $data['data'];
467461
$response_data = Utils::streamFor(json_encode($data));
468462
$this->last_response = $this->last_response->withBody($response_data);
@@ -578,13 +572,13 @@ private function forceUrlParams(string $url, array $params): string
578572
(isset($parsedUrl['host']) ? "{$parsedUrl['host']}" : '') .
579573
(isset($parsedUrl['port']) ? ":{$parsedUrl['port']}" : '') .
580574
(isset($parsedUrl['path']) ? "{$parsedUrl['path']}" : '') .
581-
(isset($parsedUrl['query']) ? "?{$parsedUrl['query']}" : '') .
575+
($parsedUrl['query'] !== '' ? "?{$parsedUrl['query']}" : '') .
582576
(isset($parsedUrl['fragment']) ? "#{$parsedUrl['fragment']}" : '')
583577
;
584578
}
579+
585580
public function getApiVersion(): string
586581
{
587582
return $this->api_version;
588583
}
589-
590584
}

‎src/sii/BheEmitidas.php‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,11 +120,13 @@ public function listarBhesEmitidas(
120120
if ($pagina_sig_codigo !== null) {
121121
$url = sprintf(
122122
$url . '&pagina_sig_codigo=%s',
123-
$pagina_sig_codigo);
123+
$pagina_sig_codigo
124+
);
124125
} else {
125126
$url = sprintf(
126127
$url . '&pagina_sig_codigo=%s',
127-
'0');
128+
'0'
129+
);
128130
}
129131
}
130132
$body = [

‎src/sii/BheRecibidas.php‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,13 @@ public function listarBhesRecibidas(
8787
if ($pagina_sig_codigo !== null) {
8888
$url = sprintf(
8989
$url . '&pagina_sig_codigo=%s',
90-
$pagina_sig_codigo);
90+
$pagina_sig_codigo
91+
);
9192
} else {
9293
$url = sprintf(
9394
$url . '&pagina_sig_codigo=%s',
94-
'00000000000000');
95+
'00000000000000'
96+
);
9597
}
9698
}
9799
$body = [

‎src/sii/Indicadores.php‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,7 @@ public function mensual(string $periodo): ResponseInterface
7373
$mes
7474
);
7575

76-
if ($this->getApiVersion() === 'v1')
77-
{
76+
if ($this->getApiVersion() === 'v1') {
7877
$url = sprintf(
7978
'/sii/indicadores/anul/%s/%s',
8079
$anio,
@@ -107,8 +106,7 @@ public function diario(string $fecha): ResponseInterface
107106
$dia
108107
);
109108

110-
if ($this->getApiVersion() === 'v1')
111-
{
109+
if ($this->getApiVersion() === 'v1') {
112110
$url = sprintf(
113111
'/sii/indicadores/anual/%s/%s/%s',
114112
$anio,

‎tests/Helpers/FunctionHelpers.php‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,12 @@ protected function tearDown(): void
3737
protected function handleApiException(ApiException $e): void
3838
{
3939
$code = (int) $e->getCode();
40-
$message = sprintf('[ApiException %d] %s',
40+
$message = sprintf(
41+
'[ApiException %d] %s',
4142
$code,
42-
$e->getMessage());
43-
if($code >= 400 && $code < 500){
43+
$e->getMessage()
44+
);
45+
if ($code >= 400 && $code < 500) {
4446
$this->markTestSkipped($message);
4547
}
4648
$this->fail($message);

0 commit comments

Comments
 (0)