fix(portal): guard livereload bind and type base URL as UrlPath

Guard the livereload HTTP server's bind the same way as the main server:
the livereload package attaches its error handler to the inner WebSocket
server, not the HTTP server it binds the port on, so a failed bind emitted
an unhandled "error" that crashed the process. On failure we now close the
server and report serverStartFailed instead.

Also model the portal base URL as a UrlPath instead of a raw string in
withApiCopilotForPortal and quickstart's defaultBaseUrl, matching the
sibling updateBuildConfigBaseUrl signature and the value-object convention.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MXbT3oxYm19pgHaviemkfa

Author: sohail2721

src/actions/portal/quickstart.ts

@@ -21,7 +21,7 @@ import { ApiService } from '../../infrastructure/services/api-service.js';
 import { DEFAULT_COPILOT_WELCOME_MESSAGE } from './copilot.js';
 
 const defaultPort: number = 23513 as const;
-const defaultBaseUrl: string = `http://localhost:${defaultPort}` as const;
+const defaultBaseUrl = new UrlPath(`http://localhost:${defaultPort}`);
 
 export class PortalQuickstartAction {
   private readonly prompts: PortalQuickstartPrompts = new PortalQuickstartPrompts();

src/actions/portal/serve.ts

@@ -75,6 +75,17 @@ export class PortalServeAction {
     const liveReloadPort = await this.networkService.getServerPort([35729, 35730, 35731, 35732]);
     const liveReloadServer = createLiveReloadServer({ port: liveReloadPort });
 
+    // livereload attaches its "error" handler to the inner WebSocket server, not to the
+    // HTTP server it binds the port on, so a failed bind (e.g. the port was taken in the
+    // gap since getServerPort) emits an unhandled "error" that would crash the process.
+    // Guard the HTTP server the same way as the main server below.
+    const liveReloadHttpServer = (liveReloadServer as unknown as { config: { server: Server } }).config.server;
+    if ((await this.waitForServerListening(liveReloadHttpServer)).isErr()) {
+      liveReloadServer.close();
+      this.prompts.serverStartFailed(liveReloadPort);
+      return ActionResult.failed();
+    }
+
     const server = this.application
       .use(connectLiveReload())
       .use(express.static(portalDirectory.toString(), { extensions: ["html"] }))

src/types/build/build.ts

@@ -211,14 +211,14 @@ export class BuildConfig {
   // Returns a copy with API Copilot enabled for a locally-served portal: stores the
   // Copilot config, points the portal base URL at the local serve URL, and turns on AI
   // editor integrations for the configured SDK languages.
-  public withApiCopilotForPortal(key: string, welcomeMessage: string, baseUrl: string): BuildConfig {
+  public withApiCopilotForPortal(key: string, welcomeMessage: string, baseUrl: UrlPath): BuildConfig {
     const portal = this.data.generatePortal!;
     return new BuildConfig({
       ...this.data,
       apiCopilotConfig: { isEnabled: true, key, welcomeMessage },
       generatePortal: {
         ...portal,
-        baseUrl,
+        baseUrl: baseUrl.toString(),
         portalSettings: PortalSettings.from(portal.portalSettings)
           .withAiIntegrations(Object.keys(portal.languageConfig))
           .toPortalSettingsData()