fix(16-fix-none-header-value): header bearing none value should be none (#17)

This commit bears a fix for local headers containing None values which are being converted into string values while merging. Now conversion will take place when the value is not None while merging the local and global headers.

closes #16

Author: sufyankhanrao

apimatic_core/request_builder.py

@@ -165,7 +165,8 @@ def process_request_headers(self, global_configuration):
             self._endpoint_logger.info('Preparing headers for {}.'.format(self._endpoint_name_for_logging))
 
         if global_headers:
-            prepared_headers = {key: str(value) for key, value in self._header_params.items()}
+            prepared_headers = {key: str(value) if value is not None else value
+                                for key, value in self._header_params.items()}
             request_headers = {**global_headers, **prepared_headers}
 
         if additional_headers:

setup.py

@@ -12,7 +12,7 @@
 
 setup(
     name='apimatic-core',
-    version='0.1.1',
+    version='0.1.2',
     description='A library that contains core logic and utilities for '
                 'consuming REST APIs using Python SDKs generated by APIMatic.',
     long_description=long_description,

tests/apimatic_core/request_builder_tests/test_request_builder.py

@@ -231,14 +231,32 @@ def test_additional_headers(self, input_additional_header_param_value, expected_
                    .additional_header('header_param', input_additional_header_param_value))
         assert http_request.headers == expected_additional_header_param_value
 
+    @pytest.mark.parametrize('input_global_header_param_value,'
+                             'input_local_header_param_value,'
+                             'expected_header_param_value', [
+                                 ('global_string', None, {'header_param': None}),
+                                 ('global_string', 'local_string', {'header_param': 'local_string'})
+                             ])
+    def test_local_and_global_headers_precedence(self, input_global_header_param_value, input_local_header_param_value,
+                                                 expected_header_param_value):
+        global_headers = {'header_param': input_global_header_param_value}
+        http_request = self.new_request_builder \
+            .header_param(Parameter()
+                          .key('header_param')
+                          .value(input_local_header_param_value)) \
+            .build(self.global_configuration.global_headers(global_headers))
+        assert http_request.headers == expected_header_param_value
+
     @pytest.mark.parametrize('input_global_header_param_value,'
                              'input_local_header_param_value,'
                              'input_additional_header_param_value,'
                              'expected_header_param_value', [
                                  ('global_string', 'local_string', 'additional_string',
-                                  {'header_param': 'additional_string'})
+                                  {'header_param': 'additional_string'}),
+                                 ('global_string', 'local_string', None,
+                                  {'header_param': None})
                              ])
-    def test_headers_precedence(self, input_global_header_param_value, input_local_header_param_value,
+    def test_all_headers_precedence(self, input_global_header_param_value, input_local_header_param_value,
                                 input_additional_header_param_value, expected_header_param_value):
         global_headers = {'header_param': input_global_header_param_value}
         additional_headers = {'header_param': input_additional_header_param_value}