Problem to use npyjs in jest

[vallsv]

Hi,

I receive that error message when i try to import npyjs from jest.

Do you have any idea if this could be removed? Maybe moved inside the load function?

    /home/mystuffs/test/node_modules/.pnpm/npyjs@0.7.0/node_modules/npyjs/index.js:1
    import fetch from 'cross-fetch';
    ^^^^^^

    SyntaxError: Cannot use import statement outside a module

      4 | import ndarray from "ndarray";
      5 | import ops from "ndarray-ops";
    > 6 | import npyjs from "npyjs";
        | ^

Without the load function we still can use the parse.

If you have any idea how to solve that it would be very useful.

Thanks a lot.

[j6k4m8]

Truthfully I haven't kept up to date on the latest in the node ecosystem — yes, it's possible that this could be removed.

Maybe moved inside the load function?

I would hesitate to do that since I think that would lead to repeated imports at runtime, which could have a substantial performance penalty... But most certainly we should make sure this is compatible with jest! Thinking....

[vallsv]

Thanks for the answer. If you tell me what to do, i can make a try.
Unfortunately i am not a specialist of JS.

[j6k4m8]

@vallsv take a look at the new #52 branch / PR; starting to modernize this repository and I think this will solve some of your problems...

[vallsv]

Nice. Ill take a look ASAP.
Also this change will be very useful for other stuffs i would like to push.
I will wait for the end of the refactoring then.

[j6k4m8]

Is this working for you now @vallsv ? I think it should be way better now!

[vallsv]

Hi @j6k4m8, i can't test anymore jest, but i have tried to update my project with the last 1.0.0, and i think there is a problem, because the exported file is "index.js", which is still the old one. Not quite sure what is the problem.

I haven't take a deep look, maybe it's a cache problem or what on my side.

[j6k4m8]

@vallsv Have you been able to take a look at this recently? I think these issues should all be resolved now :)

[vallsv]

No sorry.
But let's close it!
Thx for the fixes.

[j6k4m8]

Please do reopen or submit a new one anytime if there are still issues that are stopping you :)